Closed
Bug 744507
Opened 13 years ago
Closed 13 years ago
Cleanup GetPriorHTMLSibling/GetNextHTMLSibling
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(2 files)
|
2.22 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
7.55 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Note that none of the callers of GetPriorHTMLSibling(nsIDOMNode*, PRInt32, nsCOMPtr<nsIDOMNode>*) looks at the nsresult it returns, so it doesn't matter that we return NS_OK instead of NS_ERROR_NULL_POINTER when |node| is null.
Also note that GetChildAt will return null for out-of-bounds access, so the extra check (only in GetPriorHTMLSibling) isn't necessary.
Attachment #614087 -
Flags: review?(ehsan)
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #614088 -
Flags: review?(ehsan)
|
||
Updated•13 years ago
|
Attachment #614087 -
Flags: review?(ehsan) → review+
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 614088 [details] [diff] [review]
Part b: Add nsINode versions
Review of attachment 614088 [details] [diff] [review]:
-----------------------------------------------------------------
Beautiful!
Attachment #614088 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7a9bd13747ba
https://hg.mozilla.org/mozilla-central/rev/fd06332733e5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•