The default bug view has changed. See this FAQ.

IonMonkey: Invalidate/recompile scripts on change to ThisTypeSet

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: djvj, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Scripts do not currently get invalidated/recompiled when their typeset for 'this' is updated to include new types.

Fix by adding a freeze on the thisTypeSet returned by TypeOracle.

Not doing this is currently causing a large number of bailouts on v8-deltablue.
(Reporter)

Comment 1

5 years ago
Created attachment 614118 [details] [diff] [review]
The patch
Attachment #614118 - Flags: review?(dvander)
Comment on attachment 614118 [details] [diff] [review]
The patch

Review of attachment 614118 [details] [diff] [review]:
-----------------------------------------------------------------

Great catch. Do we need to do this for argument types as well?
Attachment #614118 - Flags: review?(dvander) → review+
(Reporter)

Comment 3

5 years ago
It's already there on parameter types.  I think the thisTypeSet case was just overlooked.
(Reporter)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.