Last Comment Bug 744535 - IonMonkey: Invalidate/recompile scripts on change to ThisTypeSet
: IonMonkey: Invalidate/recompile scripts on change to ThisTypeSet
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: general
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-11 12:29 PDT by Kannan Vijayan [:djvj]
Modified: 2012-04-12 11:02 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
The patch (440 bytes, patch)
2012-04-11 12:40 PDT, Kannan Vijayan [:djvj]
dvander: review+
Details | Diff | Splinter Review

Description Kannan Vijayan [:djvj] 2012-04-11 12:29:28 PDT
Scripts do not currently get invalidated/recompiled when their typeset for 'this' is updated to include new types.

Fix by adding a freeze on the thisTypeSet returned by TypeOracle.

Not doing this is currently causing a large number of bailouts on v8-deltablue.
Comment 1 Kannan Vijayan [:djvj] 2012-04-11 12:40:17 PDT
Created attachment 614118 [details] [diff] [review]
The patch
Comment 2 David Anderson [:dvander] 2012-04-11 13:01:43 PDT
Comment on attachment 614118 [details] [diff] [review]
The patch

Review of attachment 614118 [details] [diff] [review]:
-----------------------------------------------------------------

Great catch. Do we need to do this for argument types as well?
Comment 3 Kannan Vijayan [:djvj] 2012-04-11 13:14:41 PDT
It's already there on parameter types.  I think the thisTypeSet case was just overlooked.

Note You need to log in before you can comment on or make changes to this bug.