Closed Bug 744535 Opened 9 years ago Closed 9 years ago

IonMonkey: Invalidate/recompile scripts on change to ThisTypeSet

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: djvj, Unassigned)

Details

Attachments

(1 file)

Scripts do not currently get invalidated/recompiled when their typeset for 'this' is updated to include new types.

Fix by adding a freeze on the thisTypeSet returned by TypeOracle.

Not doing this is currently causing a large number of bailouts on v8-deltablue.
Attached patch The patchSplinter Review
Attachment #614118 - Flags: review?(dvander)
Comment on attachment 614118 [details] [diff] [review]
The patch

Review of attachment 614118 [details] [diff] [review]:
-----------------------------------------------------------------

Great catch. Do we need to do this for argument types as well?
Attachment #614118 - Flags: review?(dvander) → review+
It's already there on parameter types.  I think the thisTypeSet case was just overlooked.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.