Last Comment Bug 744564 - Allow to create EGL context from Widget provided GL context (embedding approach)
: Allow to create EGL context from Widget provided GL context (embedding approach)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: ARM Linux
: -- normal (vote)
: mozilla14
Assigned To: Oleg Romashin (:romaxa)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-11 13:33 PDT by Oleg Romashin (:romaxa)
Modified: 2012-04-12 10:19 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
More generic way to embed OGL rendering into platform provided GL context (8.70 KB, patch)
2012-04-11 13:37 PDT, Oleg Romashin (:romaxa)
roc: review+
jgilbert: review+
Details | Diff | Splinter Review
Minor addon fix (1.37 KB, patch)
2012-04-11 17:20 PDT, Oleg Romashin (:romaxa)
jgilbert: review+
Details | Diff | Splinter Review

Description Oleg Romashin (:romaxa) 2012-04-11 13:33:32 PDT
We use OGL layer manager rendering embedded into platform provided GL context for Qt only.

I think it should be more generic, so we can have GTK/Qt/Honk-toolkit-less Gecko build and be able to embed OGL/EGL rendering into any platform provided GL context (QGL/Clutter/Efl).
Comment 1 Oleg Romashin (:romaxa) 2012-04-11 13:37:10 PDT
Created attachment 614145 [details] [diff] [review]
More generic way to embed OGL rendering into platform provided GL context
Comment 2 Jeff Gilbert [:jgilbert] 2012-04-11 16:08:46 PDT
Comment on attachment 614145 [details] [diff] [review]
More generic way to embed OGL rendering into platform provided GL context

Review of attachment 614145 [details] [diff] [review]:
-----------------------------------------------------------------

R+ if try doesn't have any problem with it.

::: gfx/gl/GLLibraryEGL.h
@@ +107,5 @@
>  public:
>      GLLibraryEGL() 
>          : mInitialized(false),
>            mEGLLibrary(nsnull),
> +          mIsANGLE(false),

Is this fixing a compiler warning?
Comment 3 Oleg Romashin (:romaxa) 2012-04-11 16:09:58 PDT
Yep, init list order warning fix
Comment 4 Robert O'Callahan (:roc) (email my personal email if necessary) 2012-04-11 16:50:13 PDT
Comment on attachment 614145 [details] [diff] [review]
More generic way to embed OGL rendering into platform provided GL context

Review of attachment 614145 [details] [diff] [review]:
-----------------------------------------------------------------

rev IID on nsIWidget
Comment 5 Oleg Romashin (:romaxa) 2012-04-11 17:20:50 PDT
Created attachment 614233 [details] [diff] [review]
Minor addon fix

Minor fix for previous patch, GLContextEGL should take for mContext eglCurrentContext, not Platform Qt context.
Try build good for now, will wait all builds to be finished, and should be good to push
https://tbpl.mozilla.org/?tree=Try&rev=cc83b0d004f7
Comment 7 :Ms2ger (⌚ UTC+1/+2) 2012-04-12 10:19:25 PDT
https://hg.mozilla.org/mozilla-central/rev/527a2b7e7f4e

Note You need to log in before you can comment on or make changes to this bug.