Allow to create EGL context from Widget provided GL context (embedding approach)

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla14
ARM
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
We use OGL layer manager rendering embedded into platform provided GL context for Qt only.

I think it should be more generic, so we can have GTK/Qt/Honk-toolkit-less Gecko build and be able to embed OGL/EGL rendering into any platform provided GL context (QGL/Clutter/Efl).
(Assignee)

Comment 1

5 years ago
Created attachment 614145 [details] [diff] [review]
More generic way to embed OGL rendering into platform provided GL context
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #614145 - Flags: review?(roc)
Attachment #614145 - Flags: review?(jgilbert)
Comment on attachment 614145 [details] [diff] [review]
More generic way to embed OGL rendering into platform provided GL context

Review of attachment 614145 [details] [diff] [review]:
-----------------------------------------------------------------

R+ if try doesn't have any problem with it.

::: gfx/gl/GLLibraryEGL.h
@@ +107,5 @@
>  public:
>      GLLibraryEGL() 
>          : mInitialized(false),
>            mEGLLibrary(nsnull),
> +          mIsANGLE(false),

Is this fixing a compiler warning?
Attachment #614145 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 3

5 years ago
Yep, init list order warning fix
Comment on attachment 614145 [details] [diff] [review]
More generic way to embed OGL rendering into platform provided GL context

Review of attachment 614145 [details] [diff] [review]:
-----------------------------------------------------------------

rev IID on nsIWidget
Attachment #614145 - Flags: review?(roc) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 614233 [details] [diff] [review]
Minor addon fix

Minor fix for previous patch, GLContextEGL should take for mContext eglCurrentContext, not Platform Qt context.
Try build good for now, will wait all builds to be finished, and should be good to push
https://tbpl.mozilla.org/?tree=Try&rev=cc83b0d004f7
Attachment #614233 - Flags: review?(jgilbert)
Attachment #614233 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/527a2b7e7f4e
https://hg.mozilla.org/mozilla-central/rev/527a2b7e7f4e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.