744564 - Allow to create EGL context from Widget provided GL context (embedding approach)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

We use OGL layer manager rendering embedded into platform provided GL context for Qt only.

I think it should be more generic, so we can have GTK/Qt/Honk-toolkit-less Gecko build and be able to embed OGL/EGL rendering into any platform provided GL context (QGL/Clutter/Efl).

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: More generic way to embed OGL rendering into platform provided GL context

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 614145 [details] [diff] [review]
More generic way to embed OGL rendering into platform provided GL context

Review of attachment 614145 [details] [diff] [review]:
-----------------------------------------------------------------

R+ if try doesn't have any problem with it.

::: gfx/gl/GLLibraryEGL.h
@@ +107,5 @@
>  public:
>      GLLibraryEGL() 
>          : mInitialized(false),
>            mEGLLibrary(nsnull),
> +          mIsANGLE(false),

Is this fixing a compiler warning?

Comment 3

[Oleg Romashin (:romaxa)]

Yep, init list order warning fix

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 614145 [details] [diff] [review]
More generic way to embed OGL rendering into platform provided GL context

Review of attachment 614145 [details] [diff] [review]:
-----------------------------------------------------------------

rev IID on nsIWidget

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: Minor addon fix

Minor fix for previous patch, GLContextEGL should take for mContext eglCurrentContext, not Platform Qt context.
Try build good for now, will wait all builds to be finished, and should be good to push
https://tbpl.mozilla.org/?tree=Try&rev=cc83b0d004f7

Comment 6

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/527a2b7e7f4e

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/527a2b7e7f4e