Closed Bug 744611 Opened 8 years ago Closed 8 years ago

Use right compartment iterator when profiling scripts

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla14

People

(Reporter: bhackett1024, Assigned: bhackett1024)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Compartment iteration done during script profiling uses the wrong kind of iterator, which busts asserts in debug builds and causes profiles to be empty in release builds.
Attachment #614191 - Flags: review?(wmccloskey)
Attachment #614191 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/93605222dded
Assignee: general → bhackett1024
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Since jit-inspector is now working on today's nightly, I'm going to mark this as verified.  Presumably the AMO can now be told the add-on should work with Fx 14.  Thanks for the quick fix!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.