Use right compartment iterator when profiling scripts

VERIFIED FIXED in mozilla14

Status

()

Core
JavaScript Engine
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

unspecified
mozilla14
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 614191 [details] [diff] [review]
patch

Compartment iteration done during script profiling uses the wrong kind of iterator, which busts asserts in debug builds and causes profiles to be empty in release builds.
Attachment #614191 - Flags: review?(wmccloskey)
Attachment #614191 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/93605222dded
https://hg.mozilla.org/mozilla-central/rev/93605222dded
Assignee: general → bhackett1024
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Since jit-inspector is now working on today's nightly, I'm going to mark this as verified.  Presumably the AMO can now be told the add-on should work with Fx 14.  Thanks for the quick fix!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.