Closed
Bug 744815
Opened 13 years ago
Closed 13 years ago
stop using JSONDecodeError to be compatible with simplejson 2.0.9
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Unassigned)
Details
Attachments
(1 file)
|
3.23 KB,
patch
|
catlee
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
the aus4-dev nodes only have simplejson 2.0.9 on them, and IT says it might not be easy or quick to upgrade them. That's tracked in bug 744801. In the meantime, we can just catch ValueError instead, which is a bit of a wider net, but should be OK for now.
Attachment #614417 -
Flags: review?(catlee)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 614417 [details] [diff] [review]
use ValueError
Review of attachment 614417 [details] [diff] [review]:
-----------------------------------------------------------------
::: auslib/web/views/forms.py
@@ +33,2 @@
> klass, e, tb = sys.exc_info()
> raise Exception, e, tb
these two lines will never be reached. leftover debugging?
Attachment #614417 -
Flags: review?(catlee) → review+
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 614417 [details] [diff] [review]
use ValueError
I think I'm removing that in some other not-yet-landed patch...I'll remove it now though, just to be sure!
Jenkins run is here: https://jenkins.mozilla.org/job/Balrog/71/
Attachment #614417 -
Flags: checked-in+
|
|
Reporter | |
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
|
|
Assignee | |
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•