Full-screen HTML5 video on third of screen (with CSS max-width)

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alex.stuckey, Assigned: cpearce)

Tracking

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 614467 [details]
Mozilla Marketplace.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20100101 Firefox/12.0
Build ID: 20120328051619

Steps to reproduce:

Navigated to https://www.mozilla.org/en-US/apps/, played the video on the page (work absolutely fine). Then pressed the full-screen button in the right of the controller overlay.


Actual results:

Firefox went into full-screen mode, but the video only took up a third of the screen. (Pulled to the left) Behind it was the parent page. The video seemed to want to stick to its original resolution.

See my screenshot - a picture is worth a thousand words.


Expected results:

It should have upscaled the video to take up the rest of the screen (like most video players do in full-screen). The page should not be visible.

(A separate issue, but when in full-screen mode watching a video, the chrome (tabs, URL box, search box) should be hidden like other other video players do - maybe should be an option)

Comment 1

5 years ago
Thanks for the report!

I can reproduce on a Mac OS 10.7 nightly as well. I think I'll move this to Core and mention it in bug 730121 to notify the people responsible for the page.
Status: UNCONFIRMED → NEW
Component: Untriaged → Video/Audio
Ever confirmed: true
Product: Firefox → Core
QA Contact: untriaged → video.audio
Summary: Full-screen HTML5 video on third of screen → Full-screen HTML5 video on third of screen (with CSS max-width)
Version: 12 Branch → Trunk

Updated

5 years ago
Blocks: 730121
(Assignee)

Comment 2

5 years ago
This happens for me in [Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120416 Firefox/14.0a1] too, so not Mac specific. I wonder if it's related to bug 745067.
Blocks: 545812
Component: Video/Audio → DOM: Core & HTML
OS: Mac OS X → All
QA Contact: video.audio → general
Hardware: x86 → All
(Assignee)

Comment 3

5 years ago
This is not a regression, it's always happened as long as we've had a fullscreen API. Probably a bug in our CSS rules for :-moz-full-screen or :-moz-full-screen-ancestor.
Yeah, we should probably explicitly set min-width/min-height to 0 and max-width/max-height to none on :-moz-full-screen.  Does doing that help?
(Assignee)

Comment 5

5 years ago
Yes, that fixes this bug. Thanks bz!
(Assignee)

Comment 6

5 years ago
Created attachment 615912 [details] [diff] [review]
Patch
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Attachment #615912 - Flags: review?(roc)
Attachment #615912 - Flags: review?(roc) → review+
(Assignee)

Comment 7

5 years ago
Comment on attachment 615912 [details] [diff] [review]
Patch

Requesting approval to land on m-c. This is a simple fix to a CSS style sheet, so low risk.
Attachment #615912 - Flags: approval-mozilla-central?
Attachment #615912 - Flags: approval-mozilla-central? → approval-mozilla-central+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfcf1209c792
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/dfcf1209c792
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.