Last Comment Bug 744860 - Full-screen HTML5 video on third of screen (with CSS max-width)
: Full-screen HTML5 video on third of screen (with CSS max-width)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Chris Pearce (:cpearce)
:
Mentors:
Depends on:
Blocks: 545812 730121
  Show dependency treegraph
 
Reported: 2012-04-12 11:26 PDT by alex.stuckey
Modified: 2012-04-19 07:26 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Mozilla Marketplace.png (442.94 KB, image/png)
2012-04-12 11:26 PDT, alex.stuckey
no flags Details
Patch (948 bytes, patch)
2012-04-17 15:40 PDT, Chris Pearce (:cpearce)
roc: review+
blassey.bugs: approval‑mozilla‑central+
Details | Diff | Review

Description alex.stuckey 2012-04-12 11:26:10 PDT
Created attachment 614467 [details]
Mozilla Marketplace.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20100101 Firefox/12.0
Build ID: 20120328051619

Steps to reproduce:

Navigated to https://www.mozilla.org/en-US/apps/, played the video on the page (work absolutely fine). Then pressed the full-screen button in the right of the controller overlay.


Actual results:

Firefox went into full-screen mode, but the video only took up a third of the screen. (Pulled to the left) Behind it was the parent page. The video seemed to want to stick to its original resolution.

See my screenshot - a picture is worth a thousand words.


Expected results:

It should have upscaled the video to take up the rest of the screen (like most video players do in full-screen). The page should not be visible.

(A separate issue, but when in full-screen mode watching a video, the chrome (tabs, URL box, search box) should be hidden like other other video players do - maybe should be an option)
Comment 1 Nickolay_Ponomarev 2012-04-16 17:24:18 PDT
Thanks for the report!

I can reproduce on a Mac OS 10.7 nightly as well. I think I'll move this to Core and mention it in bug 730121 to notify the people responsible for the page.
Comment 2 Chris Pearce (:cpearce) 2012-04-16 17:37:11 PDT
This happens for me in [Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120416 Firefox/14.0a1] too, so not Mac specific. I wonder if it's related to bug 745067.
Comment 3 Chris Pearce (:cpearce) 2012-04-16 17:44:36 PDT
This is not a regression, it's always happened as long as we've had a fullscreen API. Probably a bug in our CSS rules for :-moz-full-screen or :-moz-full-screen-ancestor.
Comment 4 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-04-16 21:53:32 PDT
Yeah, we should probably explicitly set min-width/min-height to 0 and max-width/max-height to none on :-moz-full-screen.  Does doing that help?
Comment 5 Chris Pearce (:cpearce) 2012-04-17 15:36:09 PDT
Yes, that fixes this bug. Thanks bz!
Comment 6 Chris Pearce (:cpearce) 2012-04-17 15:40:42 PDT
Created attachment 615912 [details] [diff] [review]
Patch
Comment 7 Chris Pearce (:cpearce) 2012-04-17 15:54:50 PDT
Comment on attachment 615912 [details] [diff] [review]
Patch

Requesting approval to land on m-c. This is a simple fix to a CSS style sheet, so low risk.
Comment 9 :Ehsan Akhgari (out sick) 2012-04-19 07:26:58 PDT
https://hg.mozilla.org/mozilla-central/rev/dfcf1209c792

Note You need to log in before you can comment on or make changes to this bug.