744862 - promo slideshow on mozilla.org homepage not working properly

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[John Slater]

The promo slideshow on the mozilla.org homepage doesn't seem to be working properly. 

The intended behavior is that it will automatically cycle through the various promos, but for me at least that doesn't seem to be happening. Mike is reporting that it eventually starts for him, but after about a minute.

Mike, I wasn't sure what milestone to put this in.

Comment 1

[Jonathan Petto [:jpetto]]

I'm seeing this behavior in FF and Chrome, but only sporadically. I'm not yet sure how to consistently duplicate it.

John & Mike - can you let me know which browser/version you're running? Also, how frequently are you seeing the buggy behavior?

Comment 2

[Jonathan Petto [:jpetto]]

Hmm, ok, I have an idea. When you hover over the slideshow, the animation pauses. When you hover out, it starts up again. All as expected. However, one odd thing with the current layout is that the containing element of the slideshow spans the full width of the page, so if your cursor is in the left or right gutter between the slideshow images and the browser chrome, the animation will pause (which is a little confusing). If you load up the page and your cursor happened to be in that gutter, the animation wouldn't begin until you moused away.

John & Mike - Knowing the above, do you still experience the bug?

Comment 3

[John Slater]

Ah, good catch, thanks Jon. The slideshow seems to be working fine now that I know that.

Before I close the bug, would it be possible to simply speed up the rotation a bit? Right now rotates every 9-10 seconds, but shaving it down to about 7 seconds would seem to be ok.

Comment 4

[Jonathan Petto [:jpetto]]

I agree - the current 10 second interval is a bit too long. I've got it down to 7 seconds locally, which is definitely better. I think we could even go down to 6 or 5, given the speed at which people scan pages.

I've also put in a small improvement for the hover/pause state. I put an explicit size of 992px (which is the size of the slideshow images) on the slideshow wrapper, so now it only pauses when your mouse hovers over an actual image (and not in the gutters).

Let me know what you think about the interval timing. After that's set, I can make a pull request to dev.

Comment 5

[John Slater]

Thanks Jon. Those fixes all sound great to me - agreed about the further reduction to the interval timing.

Appreciate it!

Comment 6

[Jonathan Petto [:jpetto]]

Just submitted a pull request to dev. Hopefully we'll have it live soon!

Comment 7

[Mike Alexis [:malexis]]

James, putting this on your radar since have new promos going live on Thursday in bug#751427.

Comment 8

[Ty Flanagan]

I noticed that the navigation/position bullets below the promos no longer indicate the promo placement within the queue. Was this a new change to the slider?

Comment 9

[James Long (:jlongster)]

There are no pull requests, and I think I merged this into dev before. Jon, is that right? This needs QA then and when it's verified Jon can push to master and it'll go live.

Comment 10

[Jonathan Petto [:jpetto]]

Ty - Updates to the home page markup broke the selected pager bullet functionality. I refactored the CSS to fix the problem and avoid this type of bug in the future.

James - I just sent another pull request with the update mentioned above. As soon as that pull is merged and QA'd, we can push to master.

Comment 11

[John Slater]

Thanks Jon.

Comment 12

[raymond [:retornam] (inactive)]

qa-verified-trunk http://www-dev.allizom.org/en-US/

Comment 13

[James Long (:jlongster)]

This has been pushed live.

Comment 14

[raymond [:retornam] (inactive)]

verified fixed https://www.mozilla.org/en-US/