744925 - Snappy Symbolication Server - GET request throws exception

Status: VERIFIED FIXED

(Core :: Gecko Profiler, defect)

Description

[David Chan [:dchan]]

GET request to server results in an exception [1]

----------------------------------------
Exception happened during processing of request from ('127.0.0.1', 63941)
Traceback (most recent call last):
  File "/usr/lib/python2.6/SocketServer.py", line 560, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python2.6/SocketServer.py", line 322, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python2.6/SocketServer.py", line 617, in __init__
    self.handle()
  File "/usr/lib/python2.6/BaseHTTPServer.py", line 329, in handle
    self.handle_one_request()
  File "/usr/lib/python2.6/BaseHTTPServer.py", line 323, in handle_one_request
    method()
  File "symbolicationWebService.py", line 58, in do_GET
    return self.do_POST(s)
NameError: global name 's' is not defined
----------------------------------------

STR
1. curl  http://127.0.0.1:8000/

Expected
No exception

[1] - https://github.com/vdjeric/Snappy-Symbolication-Server/blob/master/symbolicationWebService.py#L57

Comment 1

[Vladan Djeric (:vladan)]

Fixed typo in self.do_GET.
Patch with all the sec review fixes: https://github.com/vdjeric/Snappy-Symbolication-Server/commit/67705706c605984e220f69469a68b455813923f5