Closed Bug 744964 Opened 9 years ago Closed 9 years ago

Plugin click-to-play popup notification icon should use the plugin icon, not the add-on icon

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
14 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 14

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Patch for bug
9.23 KB, patch
Felipe
: review+
Details | Diff | Splinter Review 
The click-to-play implementation that landed in bug 711552 used the add-on icon  (puzzle piece) in the doorhangers and popup-notification area.

Since this is directly related to plugins, we should be using the plugin icon (lego block) in both of those locations.

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/mozapps/plugins/pluginGeneric-16.png for reference.
Click-to-Play Icon also does not have a Tool-tip
Attached patch Patch for bug — — Splinter Review 
Untested on OS X & Linux.

I'll test it on OS X & Linux tomorrow, but the CSS is identical between the platforms so I don't expect any issues ;-)
Assignee: nobody → jwein
Status: NEW → ASSIGNED
Attachment #614620 - Flags: review?(felipc)
Comment on attachment 614620 [details] [diff] [review]
Patch for bug

So I guess you'll also want to make this change for the icon in about:permissions. Feel free to make it here or in bug 711618, as you prefer.
Attachment #614620 - Flags: review?(felipc) → review+
I'll make the changes to about:permissions in bug 711618.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a038c8c200f5
Flags: in-testsuite-
Flags: in-litmus-
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/a038c8c200f5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 743312
You need to log in before you can comment on or make changes to this bug.