Clean up TEST_URIs in webconsole tests

RESOLVED FIXED

Status

()

Firefox
Developer Tools: Console
P4
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwalker, Assigned: capella)

Tracking

14 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good-first-bug][fixed-in-fx-team])

Attachments

(1 attachment)

Robcee, in a review:

> const TEST_URI = "http://example.com/browser/browser/devtools/webconsole/test//test-console.html";
> 
> we should file a follow-up to cleanup those URIs.

I think he's referring to the double slash, but I'm sure he can correct me.
(In reply to Joe Walker from comment #0)
> Robcee, in a review:
> 
> > const TEST_URI = "http://example.com/browser/browser/devtools/webconsole/test//test-console.html";
> > 
> > we should file a follow-up to cleanup those URIs.
> 
> I think he's referring to the double slash, but I'm sure he can correct me.

exactly so.
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 615253 [details] [diff] [review]
Patch (v1)

Patch posted ... 32 files modified ... gonna autoland to try to verify my local tests ...
(Assignee)

Updated

5 years ago
Whiteboard: [good-first-bug] → [autoland-try: -b do -p linux64 -u all -t none][good-first-bug]
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-try: -b do -p linux64 -u all -t none][good-first-bug] → [good-first-bug]
(Assignee)

Comment 3

5 years ago
Comment on attachment 615253 [details] [diff] [review]
Patch (v1)

FYI https://tbpl.mozilla.org/?tree=Try&rev=bacfc257b906
Attachment #615253 - Flags: review?(rcampbell)
Comment on attachment 615253 [details] [diff] [review]
Patch (v1)

looks good, thanks Mark!
Attachment #615253 - Flags: review?(rcampbell) → review+
Whiteboard: [good-first-bug] → [good-first-bug][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/b8b2b94ae5e5
Whiteboard: [good-first-bug][land-in-fx-team] → [good-first-bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b8b2b94ae5e5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Version: unspecified → 14 Branch
You need to log in before you can comment on or make changes to this bug.