Closed Bug 745119 Opened 8 years ago Closed 8 years ago

Clean up TEST_URIs in webconsole tests

Categories

(DevTools :: Console, defect, P4)

14 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jwalker, Assigned: capella)

Details

(Whiteboard: [good-first-bug][fixed-in-fx-team])

Attachments

(1 file)

Robcee, in a review:

> const TEST_URI = "http://example.com/browser/browser/devtools/webconsole/test//test-console.html";
> 
> we should file a follow-up to cleanup those URIs.

I think he's referring to the double slash, but I'm sure he can correct me.
(In reply to Joe Walker from comment #0)
> Robcee, in a review:
> 
> > const TEST_URI = "http://example.com/browser/browser/devtools/webconsole/test//test-console.html";
> > 
> > we should file a follow-up to cleanup those URIs.
> 
> I think he's referring to the double slash, but I'm sure he can correct me.

exactly so.
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attached patch Patch (v1)Splinter Review
Patch posted ... 32 files modified ... gonna autoland to try to verify my local tests ...
Whiteboard: [good-first-bug] → [autoland-try: -b do -p linux64 -u all -t none][good-first-bug]
Whiteboard: [autoland-try: -b do -p linux64 -u all -t none][good-first-bug] → [good-first-bug]
Comment on attachment 615253 [details] [diff] [review]
Patch (v1)

looks good, thanks Mark!
Attachment #615253 - Flags: review?(rcampbell) → review+
Whiteboard: [good-first-bug] → [good-first-bug][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/b8b2b94ae5e5
Whiteboard: [good-first-bug][land-in-fx-team] → [good-first-bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b8b2b94ae5e5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Version: unspecified → 14 Branch
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.