745197 - Add a hook in Bugzilla::Error::_throw_error() so that extensions can control the way to throw errors

Status: RESOLVED FIXED

(Bugzilla :: Extensions, enhancement)

Description

[Frédéric Buclin]

Testopia uses JSON heavily to refresh its pages (rather than reloading the whole HTML pages again and again) and when something goes wrong, it must format errors to be understood by the JSON client. Extensions can define their own ERROR_MODE_* codes and pass them to Bugzilla->error_mode(), but they have no way to take advantage of this as Bugzilla::Error::_throw_error() has no hook to handle custom error codes. So we need one.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Ideally, I would like to take it for 4.2.1, as it's needed by Testopia to work without having to hack the source code of Bugzilla.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1.1

Oops, I forgot to include code-error.html.tmpl in the patch. I added the same ID as in user-error.html.tmpl, which already defines it.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 614857 [details] [diff] [review]
patch, v1.1

Review of attachment 614857 [details] [diff] [review]:
-----------------------------------------------------------------

No issues that I can see and the hook works as expected in my testing. r=dkl

Comment 4

[Frédéric Buclin]

Great, thanks! :)

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Error.pm
modified Bugzilla/Hook.pm
modified extensions/Example/Extension.pm
modified template/en/default/global/code-error.html.tmpl
Committed revision 8201.


Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/Error.pm
modified Bugzilla/Hook.pm
modified extensions/Example/Extension.pm
modified template/en/default/global/code-error.html.tmpl
Committed revision 8077.

Comment 6

[Frédéric Buclin]

Added to relnotes for 4.2.1.