745202 - Libpng 1.5.10 check for invalid palette index is ignored.

Status: RESOLVED FIXED

Description

[Glenn Randers-Pehrson]

Libpng-1.5.10 adds a new function to check the palette-index for valid range.  Currently we simply display such pixels as black, which is harmless.  The libpng-1.5.0 feature only issues a warning, and we ignore warnings if PR_LOGGING is not defined.  For speed, we should avoid this new check which involves another pass over each row of pixels.  The embedded libpng will skip the check, but the system library does not.  Libpng-1.5.10 provides a "png_set_check_for_invalid_index()" function that can be used to avoid the check.

Comment 1

[Glenn Randers-Pehrson]

Created attachment 614792 [details] [diff] [review]
v00 Disable palette-index checking in the PNG decoder

offers a small performance improvement when using a system libpng 1.5.10 and later.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd616252640b

Sorry for losing track of this one...

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bd616252640b