Closed
Bug 745202
Opened 14 years ago
Closed 13 years ago
Libpng 1.5.10 check for invalid palette index is ignored.
Categories
(Core :: Graphics: ImageLib, enhancement)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: glennrp+bmo, Assigned: glennrp+bmo)
Details
Attachments
(1 file)
|
1.49 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
Libpng-1.5.10 adds a new function to check the palette-index for valid range. Currently we simply display such pixels as black, which is harmless. The libpng-1.5.0 feature only issues a warning, and we ignore warnings if PR_LOGGING is not defined. For speed, we should avoid this new check which involves another pass over each row of pixels. The embedded libpng will skip the check, but the system library does not. Libpng-1.5.10 provides a "png_set_check_for_invalid_index()" function that can be used to avoid the check.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•14 years ago
|
||
offers a small performance improvement when using a system libpng 1.5.10 and later.
|
||
Updated•14 years ago
|
Attachment #614792 -
Flags: review?(joe)
|
||
Updated•13 years ago
|
Attachment #614792 -
Flags: review?(joe) → review+
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Comment 2•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd616252640b
Sorry for losing track of this one...
Flags: in-testsuite-
Keywords: checkin-needed
|
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•