The default bug view has changed. See this FAQ.

Libpng 1.5.10 check for invalid palette index is ignored.

RESOLVED FIXED in mozilla17

Status

()

Core
ImageLib
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Glenn Randers-Pehrson, Assigned: Glenn Randers-Pehrson)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Libpng-1.5.10 adds a new function to check the palette-index for valid range.  Currently we simply display such pixels as black, which is harmless.  The libpng-1.5.0 feature only issues a warning, and we ignore warnings if PR_LOGGING is not defined.  For speed, we should avoid this new check which involves another pass over each row of pixels.  The embedded libpng will skip the check, but the system library does not.  Libpng-1.5.10 provides a "png_set_check_for_invalid_index()" function that can be used to avoid the check.
(Assignee)

Updated

5 years ago
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 614792 [details] [diff] [review]
v00 Disable palette-index checking in the PNG decoder

offers a small performance improvement when using a system libpng 1.5.10 and later.
Attachment #614792 - Flags: review?(joe)
Attachment #614792 - Flags: review?(joe) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd616252640b

Sorry for losing track of this one...
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bd616252640b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.