745211 - Remove SetScriptContext from nsIScriptGlobalObject

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Apart from the one call in nsXBLDocumentInfo::~nsXBLDocumentInfo(), SetScriptContext is only called from EnsureScriptEnvironment(), so it is rather silly to put it on nsIScriptGlobalObject. Also, inlining the implementations allows to simplify them, as we know the argument isn't null.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1.1

And now a patch that compiles...

Comment 2

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Comment on attachment 614820 [details] [diff] [review]
Patch v1.1

Review of attachment 614820 [details] [diff] [review]:
-----------------------------------------------------------------

One substantive comment. r=me with it addressed.

::: dom/base/nsIScriptGlobalObject.h
@@ -138,5 @@
> -   * Set a new language context for this global.  The native global for the
> -   * context is created by the context's GetNativeGlobal() method.
> -   */
> -
> -  virtual nsresult SetScriptContext(nsIScriptContext *aContext) = 0;

You need to bump the IID for nsIScriptGlobalObject.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/fb420fe0c2a4