Created attachment 614862 [details] [diff] [review] patch, bail out of whatever we're doing if SetupCairoFont fails We have a number of places where we call gfxFont::SetupCairoFont(context) and then proceed on the assumption that the font has indeed been set up properly. We should check those calls for failure (the method returns a success/failure bool), and just bail out if something went wrong.
Attachment #614862 - Flags: review?(jdaggett)
Comment on attachment 614862 [details] [diff] [review] patch, bail out of whatever we're doing if SetupCairoFont fails This seems fine but I think the warning should take place everywhere SetupCairoFont fails, for example in the several calls within various ShapeWord methods. I don't like the idea of failing quietly in some places.
I didn't add those in all places because if ShapeWord returns false, its callers (e.g. gfxFont::GetShapedWord) already log a warning, so it seemed excessive amount to warn from within it as well.
Assignee: nobody → jfkthame
Target Milestone: --- → mozilla14
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.