745261 - check calls to SetupCairoFont for failure

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew (:jfkthame)]

Attachment: patch, bail out of whatever we're doing if SetupCairoFont fails

We have a number of places where we call gfxFont::SetupCairoFont(context) and then proceed on the assumption that the font has indeed been set up properly. We should check those calls for failure (the method returns a success/failure bool), and just bail out if something went wrong.

Comment 1

[John Daggett (:jtd)]

Comment on attachment 614862 [details] [diff] [review]
patch, bail out of whatever we're doing if SetupCairoFont fails

This seems fine but I think the warning should take place everywhere
SetupCairoFont fails, for example in the several calls within various
ShapeWord methods.  I don't like the idea of failing quietly in some places.

Comment 2

[Jonathan Kew (:jfkthame)]

I didn't add those in all places because if ShapeWord returns false, its callers (e.g. gfxFont::GetShapedWord) already log a warning, so it seemed excessive amount to warn from within it as well.

Comment 3

[Jonathan Kew (:jfkthame)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5cd53eb0cf9

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/e5cd53eb0cf9