Last Comment Bug 745266 - Operator precedence is wrong in nsEventStateManager::PreHandleEvent
: Operator precedence is wrong in nsEventStateManager::PreHandleEvent
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: David Humphrey (:humph)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: buildwarning 633602
  Show dependency treegraph
 
Reported: 2012-04-13 11:23 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-04-17 18:28 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (1.24 KB, patch)
2012-04-13 12:13 PDT, David Humphrey (:humph)
bugs: review+
Details | Diff | Splinter Review
Fix (r=smaug) (1.43 KB, patch)
2012-04-16 10:00 PDT, David Humphrey (:humph)
no flags Details | Diff | Splinter Review
Fix (r=smaug) (1.39 KB, patch)
2012-04-16 10:02 PDT, David Humphrey (:humph)
no flags Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-04-13 11:23:20 PDT
It has (trusted & mouse & real) | scroll, should be trusted & ((mouse & real) | scroll)
Comment 1 David Humphrey (:humph) 2012-04-13 12:13:37 PDT
Created attachment 614876 [details] [diff] [review]
Fix
Comment 2 David Humphrey (:humph) 2012-04-16 10:00:39 PDT
Created attachment 615369 [details] [diff] [review]
Fix (r=smaug)

Same patch, but with checkin comment/author added.
Comment 3 David Humphrey (:humph) 2012-04-16 10:01:13 PDT
This can land.
Comment 4 David Humphrey (:humph) 2012-04-16 10:02:34 PDT
Created attachment 615372 [details] [diff] [review]
Fix (r=smaug)

...with correct commit message this time.
Comment 5 Daniel Holbert [:dholbert] 2012-04-16 14:30:10 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/f59dff115daa
Comment 6 Marco Bonardo [::mak] 2012-04-17 08:01:41 PDT
the commit message has a wrong bug number
https://hg.mozilla.org/mozilla-central/rev/f59dff115daa
Comment 7 Daniel Holbert [:dholbert] 2012-04-17 09:45:00 PDT
(sorry -- I glossed over that in my pre-landing sanity-check)
Comment 8 Daniel Holbert [:dholbert] 2012-04-17 09:47:06 PDT
hmm, and bug 745255 (the bug # used in the commit) is hidden, so I can't just add a comment over there to direct people to this bug.

I'll backout & re-land this with the correct bug number.
Comment 9 Daniel Holbert [:dholbert] 2012-04-17 09:58:12 PDT
Backed out:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/328b56d0b34c
...and re-landed w/ correct bug number:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/bb0ab2ceb031
Comment 10 David Humphrey (:humph) 2012-04-17 11:31:34 PDT
Apologies, and thanks for fixing.
Comment 11 Ed Morley [:emorley] 2012-04-17 18:28:12 PDT
https://hg.mozilla.org/mozilla-central/rev/bb0ab2ceb031

Note You need to log in before you can comment on or make changes to this bug.