The default bug view has changed. See this FAQ.

Fix recent a11y build warnings

RESOLVED FIXED in mozilla14

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 614873 [details] [diff] [review]
Patch v1
Attachment #614873 - Flags: review?(markcapella)
Comment on attachment 614873 [details] [diff] [review]
Patch v1

Review of attachment 614873 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.
Attachment #614873 - Flags: review+
Comment on attachment 614873 [details] [diff] [review]
Patch v1

>   nsresult rv = GetMaximumValue(&maxValue);
>-  NS_ENSURE_SUCCESS(rv, );
>-  if (maxValue == 0)
>+  if (NS_FAILED(rv) || maxValue == 0)
>     return;

I'm fine with this since I wasn't completely sure I wanted to warn there, but that change isn't quiet equivelent.

On the other hand I tend to think we should either tell gcc to shut up about this warning, or implement a one arg version of the macro as iirc Neil suggested.

Comment 3

5 years ago
yep, I think the change is ok. We don't need to warn about incorrect markup.

Mark, please do a review.
Attachment #614873 - Flags: review?(markcapella) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f3aa582f0137
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.