745287 - Fix recent a11y build warnings

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 614873 [details] [diff] [review]
Patch v1

Review of attachment 614873 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 614873 [details] [diff] [review]
Patch v1

>   nsresult rv = GetMaximumValue(&maxValue);
>-  NS_ENSURE_SUCCESS(rv, );
>-  if (maxValue == 0)
>+  if (NS_FAILED(rv) || maxValue == 0)
>     return;

I'm fine with this since I wasn't completely sure I wanted to warn there, but that change isn't quiet equivelent.

On the other hand I tend to think we should either tell gcc to shut up about this warning, or implement a one arg version of the macro as iirc Neil suggested.

Comment 3

[alexander :surkov (:asurkov)]

yep, I think the change is ok. We don't need to warn about incorrect markup.

Mark, please do a review.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f3aa582f0137