Closed Bug 745287 Opened 8 years ago Closed 8 years ago

Fix recent a11y build warnings

Categories

(Core :: Disability Access APIs, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #614873 - Flags: review?(markcapella)
Comment on attachment 614873 [details] [diff] [review]
Patch v1

Review of attachment 614873 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.
Attachment #614873 - Flags: review+
Comment on attachment 614873 [details] [diff] [review]
Patch v1

>   nsresult rv = GetMaximumValue(&maxValue);
>-  NS_ENSURE_SUCCESS(rv, );
>-  if (maxValue == 0)
>+  if (NS_FAILED(rv) || maxValue == 0)
>     return;

I'm fine with this since I wasn't completely sure I wanted to warn there, but that change isn't quiet equivelent.

On the other hand I tend to think we should either tell gcc to shut up about this warning, or implement a one arg version of the macro as iirc Neil suggested.
yep, I think the change is ok. We don't need to warn about incorrect markup.

Mark, please do a review.
Attachment #614873 - Flags: review?(markcapella) → review+
https://hg.mozilla.org/mozilla-central/rev/f3aa582f0137
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.