745291 - Superfluous ; in X11Util.h

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 614875 [details] [diff] [review]
Patch v1

Well spotted, thanks.

Comment 2

[Landry Breuil (:gaston)]

When will this reland ? I'm hitting this and it triggers a build failure, see http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/358/steps/build/logs/stdio

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Given approval rules, I'm not planning to land anything before branching. Feel free to get approval and push if you like.

Comment 4

[Landry Breuil (:gaston)]

Comment on attachment 614875 [details] [diff] [review]
Patch v1

Given that it fixes a hard build failure on some NPOTB archs.. it costs nothing to ask for approval.

Comment 5

[Landry Breuil (:gaston)]

Not sure what is the commit policy now that m-c is approval only, but setting checki-needed..

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/370f6e1f4864

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/370f6e1f4864