Last Comment Bug 745291 - Superfluous ; in X11Util.h
: Superfluous ; in X11Util.h
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks: buildwarning 728171
  Show dependency treegraph
 
Reported: 2012-04-13 12:12 PDT by :Ms2ger
Modified: 2012-04-20 10:38 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (876 bytes, patch)
2012-04-13 12:12 PDT, :Ms2ger
dteller: review+
blassey.bugs: approval‑mozilla‑central+
Details | Diff | Review

Description :Ms2ger 2012-04-13 12:12:00 PDT
Created attachment 614875 [details] [diff] [review]
Patch v1
Comment 1 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-04-13 13:15:13 PDT
Comment on attachment 614875 [details] [diff] [review]
Patch v1

Well spotted, thanks.
Comment 2 Landry Breuil (:gaston) 2012-04-17 08:41:01 PDT
When will this reland ? I'm hitting this and it triggers a build failure, see http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/358/steps/build/logs/stdio
Comment 3 :Ms2ger 2012-04-18 03:59:41 PDT
Given approval rules, I'm not planning to land anything before branching. Feel free to get approval and push if you like.
Comment 4 Landry Breuil (:gaston) 2012-04-18 12:28:48 PDT
Comment on attachment 614875 [details] [diff] [review]
Patch v1

Given that it fixes a hard build failure on some NPOTB archs.. it costs nothing to ask for approval.
Comment 5 Landry Breuil (:gaston) 2012-04-19 10:22:14 PDT
Not sure what is the commit policy now that m-c is approval only, but setting checki-needed..
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-04-19 15:54:02 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/370f6e1f4864
Comment 7 :Ehsan Akhgari (out sick) 2012-04-20 10:38:05 PDT
https://hg.mozilla.org/mozilla-central/rev/370f6e1f4864

Note You need to log in before you can comment on or make changes to this bug.