745415 - BrowserID module must use appShellService to append the hidden iframe

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, defect)

Description

[Anant Narayanan [:anant]]

The _createFrame method in the BrowserID module creates an iframe and appends it to the most recent browser window, which will fail if there was none. Instead, it should use appShellService to obtain a hiddenDOMWindow:

let appShell = Cc["@mozilla.org/appshell/appShellService;1"]
  .getService(Ci.nsIAppShellService);
let hiddenDOMWindow = appShell.hiddenDOMWindow;
let doc = hiddenDOMWindow.document;

Comment 1

[Anant Narayanan [:anant]]

Fixed in the latest version of patch in bug 745345.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Looks like this wasn't actually fixed in that patch?

Comment 3

[Anant Narayanan [:anant]]

One of the attachment versions had the fix: https://bug745345.bugzilla.mozilla.org/attachment.cgi?id=628588 but it didn't make it to the final version, I'm investigating why...