Maintenance service description should wrap to allow long localizations

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Installer
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: flod, Assigned: rstrong)

Tracking

Trunk
Firefox 13
x86
Windows 7
Points:
---

Firefox Tracking Flags

(firefox12 affected, firefox13+ verified, firefox14+ verified, firefox15+ verified, firefox-esr10 unaffected, status1.9.2 unaffected)

Details

(Whiteboard: [qa+])

Attachments

(6 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 615015 [details]
Screnshot of Italian installer (12b4)

Current Italian localization of OPTIONAL_COMPONENTS_DESC is "Il servizio di manutenzione consente di installare gli aggiornamenti di $BrandShortName senza bisogno di interventi da parte dell'utente.", which should be around 130 characters. The result is shown in the attachment: the string is cut before character #100

According to notes in installer/custom.properties I can't add a new line on my locale.
"You can use \n to create a newline in the string but only when the string from en-US contains a \n."

Is it possible to make that line wrap? I can try to shorten that string somehow, but the resulting translation would be less clear for users (and that's an important piece of information). I also suspect that this issue involves other locales, not only Italian (maybe German and French, they're around 100 characters long).
(Reporter)

Updated

5 years ago
OS: Windows XP → Windows 7
(Reporter)

Updated

5 years ago
Duplicate of this bug: 747711

Comment 2

5 years ago
I have the same "issue" with the German setup.

Comment 3

5 years ago
Created attachment 617326 [details]
Firefox 12 Setup with the truncated German text

Firefox 12 Setup with the truncated German text
Created attachment 617327 [details]
Same problem in Russian installer
Duplicate of this bug: 747714
Blocks: 481815
Created attachment 625775 [details]
patch rev1 - extend label to accommodate text

I need to check the UI so holding off on requesting review until after I have done this.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Created attachment 625812 [details]
screenshots with fix
Created attachment 625813 [details] [diff] [review]
patch rev2 - extend label to accommodate text

This should be sufficient
Attachment #625775 - Attachment is obsolete: true
Attachment #625813 - Flags: review?(netzen)
Comment on attachment 625813 [details] [diff] [review]
patch rev2 - extend label to accommodate text

Thanks for taking this, looks good.
Attachment #625813 - Flags: review?(netzen) → review+
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/21be0265c5f3

Adding tracking flags.

Drivers, this causes locales with longer than en-US text to have the text cut-off for the description of the maintenance service in the installer. It is only shown during a custom installation.
status1.9.2: --- → unaffected
status-firefox-esr10: --- → unaffected
status-firefox12: --- → affected
status-firefox13: --- → affected
status-firefox14: --- → affected
status-firefox15: --- → affected
tracking-firefox13: --- → ?
tracking-firefox14: --- → ?
tracking-firefox15: --- → ?
Whiteboard: [fixed-in-fx-team]
Comment on attachment 625813 [details] [diff] [review]
patch rev2 - extend label to accommodate text

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 481815
User impact if declined: When installing the text in the installer is not displayed on some locales.
Testing completed (on m-c, etc.): Tested locally
Risk to taking this patch (and alternatives if risky): Low Risk
String or UUID changes made by this patch: None

Note: I am ok with not taking this but it is extremely low risk and the UX without it is very bad / unprofessional.
Attachment #625813 - Flags: approval-mozilla-beta?
Attachment #625813 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/21be0265c5f3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 15

Comment 13

5 years ago
any chance to also land this for beta and aurora?
> any chance to also land this for beta and aurora?

Beta and Aurora have been requested in Comment 11, release drivers will make a decision soon and update the bug.

Comment 15

5 years ago
ok, thanks :)
Comment on attachment 625813 [details] [diff] [review]
patch rev2 - extend label to accommodate text

[Triage Comment]
Approved for Aurora 14. If landed today, thus making it into FF13beta5, also approved for Beta 13.
Attachment #625813 - Flags: approval-mozilla-beta?
Attachment #625813 - Flags: approval-mozilla-beta+
Attachment #625813 - Flags: approval-mozilla-aurora?
Attachment #625813 - Flags: approval-mozilla-aurora+
I'll land it for Rob now in both
http://hg.mozilla.org/releases/mozilla-beta/rev/6632d9bde7f9
http://hg.mozilla.org/releases/mozilla-aurora/rev/a2c9dd0b3312
status-firefox13: affected → fixed
status-firefox14: affected → fixed
status-firefox15: affected → fixed
Thanks for landing this Brian!
Target Milestone: Firefox 15 → Firefox 13

Updated

5 years ago
tracking-firefox13: ? → +
tracking-firefox14: ? → +
tracking-firefox15: ? → +

Comment 20

5 years ago
ok, fix is part of Firefox 13b5 and works fine. Now I can read the complete text :)

Comment 21

5 years ago
Created attachment 626826 [details]
Firefox 13 Setup with the complete German text

Comment 22

5 years ago
(In reply to André Ziegler from comment #21)
> Created attachment 626826 [details]
> Firefox 13 Setup with the complete German text

Thanks for tracking and testing this and to Francesco for reporting it in the first place!
Whiteboard: [qa+]
Did the text in some of the locals changed? For e.g the text on the Italian Installer is different between Firefox 12 beta 5 and Firefox 13 beta 6.
Verified using Firefox 13 beta 6 on Windows 7 and on Windows XP that the text from the Installer that refers to the Maintenance service is complete. 

Verified on the following locals: de, ru, it and fr.
Build-Identifikator: Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
Идентификатор сборки: Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
Identificativo build: Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
Identifiant de compilation : Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
Идентификатор сборки: Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
status-firefox13: fixed → verified
Verified using Firefox 14 beta 7 on Windows XP and on Windows 7 that the text from the Installer that refers to the Maintenance service is complete.

Verified on the locals: de, fr, it and ru:

Build-Identifikator: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20100101 Firefox/14.0
Build-Identifikator: Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0

Identifiant de compilation : Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20100101 Firefox/14.0
Identifiant de compilation : Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0

Identificativo build: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20100101 Firefox/14.0
Identificativo build: Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0

Идентификатор сборки: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20100101 Firefox/14.0
Идентификатор сборки: Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0
status-firefox14: fixed → verified
Verified on Win XP and on Win 7 using Firefox 15 beta 3 that - the text from the installer that refers to the Mozilla Maintenance Service is complete. Verified on several locals: de, fr, it and ru.

Build-Identifikator: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20100101 Firefox/15.0
Build-Identifikator: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0

Identifiant de compilation : Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20100101 Firefox/15.0
Identifiant de compilation : Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0

Identificativo build: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20100101 Firefox/15.0
Identificativo build: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0

Идентификатор сборки: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20100101 Firefox/15.0
Идентификатор сборки: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0
status-firefox15: fixed → verified
You need to log in before you can comment on or make changes to this bug.