745460 - Comment toggling text is not localizable because it's in a .js file

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment toggling text (the "title" tooltip of the [-] and [+] boxes of comments in show_bug.cgi) is not localizable because it's in a .js file. The attached patch moves the text to a template.

Comment 1

[Frédéric Buclin]

I would like a solution where we keep the two current strings. If some comments are collapsed only, the new text is ambiguous as we don't know if it's going to collapse or expand comments.

Comment 2

[Marc Schumann [:Wurblzap]]

I don't understand -- the text is about the comment you're seeing, so if it's collapsed, toggling will expand, and if it's expanded, it'll collapse... What's the situation you mean where you cannot see what'll happen?

Comment 3

[Frédéric Buclin]

Ah sorry, I had the two links "Collapse All Comments" and "Expand All Comments" in mind. I forgot we had tooltips for the [+] and [-] links. :)

Comment 4

[Frédéric Buclin]

Comment on attachment 615057 [details] [diff] [review]
Patch

>=== modified file 'template/en/default/bug/comments.html.tmpl'
>+              addCollapseLink([% count %], 'Toggle comment display.'); // -->

Nit: remove the trailing period. Not very pretty in a tooltip.


I didn't test your patch, but it looks good. And I assume you tested it. So r=LpSolit

Comment 5

[Marc Schumann [:Wurblzap]]

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified js/comments.js
modified template/en/default/bug/comments.html.tmpl
Committed revision 8074.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified js/comments.js
modified template/en/default/bug/comments.html.tmpl
Committed revision 8198.