745483 - Fatal assert on startup with javascript.options.typeinference set to false

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jesse Ruderman]

If I set
  user_pref("javascript.options.typeinference", false);
I hit a fatal assertion on startup:

Assertion failure: JS_GetOptions(cx) & ((uint32_t)1 << (18)), at js/xpconnect/src/nsXPConnect.cpp:1212

The assertion was added in bug 744034. I don't think this is a reasonable thing to assert; the pref exists for a reason.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Don't assert that TI is enabled when the pref is disabled. v1

Right. Duh.

Flagging jdm for review, mostly to make absolutely sure that the pref change is scoped to this test.

Comment 2

[Bobby Holley (:bholley)]

Pushed to m-i: http://hg.mozilla.org/integration/mozilla-inbound/rev/69fdff02f85d

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This asserts when the browser starts in safe mode too.

Comment 4

[Bobby Holley (:bholley)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #3)
> This asserts when the browser starts in safe mode too.

Filed bug 745661 for this.

Comment 5

[Paul Wright]

This was merged to M-C on 4/16/12.  Changeset 69fdff02f85d

Comment 6

[Bobby Holley (:bholley)]

resolving fixed per comment 5.