Closed
Bug 745501
Opened 12 years ago
Closed 12 years ago
Simple string preferences don't get sent to Java properly
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox14 fixed, blocking-fennec1.0 -)
RESOLVED
FIXED
Firefox 14
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
|
1.73 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
The code in browser.js calls getComplexValue which throws an exception. Fennec XUL used to do something different: http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/config.js#341 and we should handle that case too.
Attachment #615101 -
Flags: review?(mark.finkle)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 615101 [details] [diff] [review] Patch Bug 719662 makes it seem like the nsISupportsString case is handled by the nsIPrefLocalizedString, but this patch looks good for handling a fallback to plain char string prefs.
Attachment #615101 -
Flags: review?(mark.finkle) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #1) > Bug 719662 makes it seem like the nsISupportsString case is handled by the > nsIPrefLocalizedString, I was seeing it throw an exception when accessing a pref whose value I had set to be the empty string "" in mobile/android/app/mobile.js. Maybe that case is treated differently? Anyway, this takes care of it. https://hg.mozilla.org/integration/mozilla-inbound/rev/1ce567bc7915
status-firefox14:
--- → fixed
Target Milestone: --- → Firefox 14
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1ce567bc7915
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
blocking-fennec1.0: ? → -
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•