Last Comment Bug 745508 - Remove unused "From an HTML File" mode from the migration wizard
: Remove unused "From an HTML File" mode from the migration wizard
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Migration (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 14
Assigned To: Mano (::mano, needinfo? for any questions; not reading general bugmail)
:
: Matthew N. [:MattN] (PM me if requests are blocking you)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-14 21:40 PDT by Mano (::mano, needinfo? for any questions; not reading general bugmail)
Modified: 2012-04-24 04:37 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (7.99 KB, patch)
2012-04-14 21:40 PDT, Mano (::mano, needinfo? for any questions; not reading general bugmail)
mak77: review+
Details | Diff | Splinter Review

Description Mano (::mano, needinfo? for any questions; not reading general bugmail) 2012-04-14 21:40:56 PDT
Created attachment 615108 [details] [diff] [review]
patch

I deliberately kept this patch very scoped.
Comment 1 Mardeg 2012-04-14 21:52:31 PDT
Would bug 429583 block this?
Comment 2 Mano (::mano, needinfo? for any questions; not reading general bugmail) 2012-04-15 01:26:21 PDT
I don't think so.  The patch there (from 2009) relies on the old behavior of the places organizer: opening the migration wizard for html-file import.  This has changed in the meanwhile (for quite a long time now, I think), and I'm not sure if the now-dating-again ui-review makes the patch more relevant now, given that.

All in all, I think fixing that bug would involve introducing new UI, independent from the migration wizard.
Comment 3 Marco Bonardo [::mak] 2012-04-18 07:38:44 PDT
Comment on attachment 615108 [details] [diff] [review]
patch

Review of attachment 615108 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup!

This can land with a=desktop-only
Comment 4 Mano (::mano, needinfo? for any questions; not reading general bugmail) 2012-04-23 12:32:52 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/e481ab44f21f
Comment 5 Ed Morley [:emorley] 2012-04-24 04:37:06 PDT
https://hg.mozilla.org/mozilla-central/rev/e481ab44f21f

Note You need to log in before you can comment on or make changes to this bug.