74567 - Crash on Undo Delete in mail window after del in search ui

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using apr3 commercial trunk build

When using Undo Delete message in mail window after having deleted a message in
the search messages ui results pane, a crash occurs.  Since search ui doesn't
inherently provide an Undo, I think the Undo manager is getting confused as to
what was last deleted...

Steps:
1.  Login to mail account (I tested with IMAP account). Select a message in
INBOX and Delete it. Message is deleted from thread pane.
2.  Search|Search Mailnews.  Initiate a simple search which will yield results
found in the INBOX.
3.  In the search results pane, select a message and delete it.
4.  Go to the mail window and Edit|Undo Delete.

Result:  crash.

I'm not sure who this belongs to, gayatrib for search or someone else for undo
manager.

Comment 1

[laurel]

Attachment: talkback 28616818

Comment 2

[(not reading, please use [e-mail] instead)]

crash -> 0.9

Comment 3

[scottputterman]

moving to mozilla0.9.1

Comment 4

[scottputterman]

reassigning to naving

Comment 5

[Navin Gupta]

This seems to have been fixed by my recent checkin for other search bugs. 

Comment 6

[Navin Gupta]

I think we should disable undo/redo when the user deletes in the search window 
because it tries to do the operation on mail3pane window. 

Comment 7

[scottputterman]

I agree. Or, I'd at least want it to only pertain to the search window. 

Comment 8

[laurel]

Hmm, I think something is wrong here.
Once I delete in search I can no longer undo a delete outside of search -- we
seem to shut down the Undo feature (not that it worked all that well anyway).
Still need to check more platforms, but just a heads up that we might've broken
Undo.

Comment 9

[laurel]

Well, there's no crash that I can see.
But I'm not sure what we intended as far as the "disable undo" thing.  
From what I've seen on all platforms:
1) If you delete a mail message in 3pane, then go to search and delete a search
result, you are subsequently able to undo deletes after closing search.
2) If you launch, login to mail, go to search and delete a message from search
results you will not have the use of Undo Delete for the search deletion or any
subsequent 3-pane window message deletions.
Is that what you intended? Shall I log a bug at least on situation #2?

Comment 10

[scottputterman]

In my opinion, a delete in Search should be undoable from the search window and
not from the 3 pane.  Doing an undo in search should not prevent future
undo/redo in the 3 pane.

Comment 11

[Navin Gupta]

i have also seen this; you can undo for the search results only sometimes. Not 
sure why, but my changes did not change anything for undo. Yes, you can log a bug 
for situation #2. 

Comment 12

[laurel]

logged bug 78240 for the scenario #2 described above

Comment 13

[laurel]

Marking this bug verified as of apr 30 commercial trunk build: win98, linux
rh6.2 and mac OS 9.0.
I haven't seen any crash in the steps originally described.  I've got a couple
scenarios I'm investigating more, but will log a bug with specific steps in
that/those cases if I can reproduce.