Last Comment Bug 745703 - XBL for menu-button inherits accessKey instead of accesskey
: XBL for menu-button inherits accessKey instead of accesskey
Product: Core
Classification: Components
Component: XUL (show other bugs)
: unspecified
: All All
-- minor (vote)
: mozilla16
Assigned To: Atte Kemppilä [:atte]
: Neil Deakin
Depends on:
  Show dependency treegraph
Reported: 2012-04-16 02:40 PDT by Daniel Dawson
Modified: 2012-06-27 03:34 PDT (History)
3 users (show)
jaws: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (1.12 KB, patch)
2012-06-25 11:29 PDT, Atte Kemppilä [:atte]
enndeakin: review+
Details | Diff | Splinter Review

Description User image Daniel Dawson 2012-04-16 02:40:34 PDT
The content button in the XBL at chrome://global/content/bindings/button.xml#menu-button has "accessKey" (uppercase "K") in its inherits list. But this should be "accesskey" (lowercase). This usually results in the accesskey not being underlined, although the key still activates the button. Also, if the accesskey comes from a command element, it becomes underlined on mouseover.
Comment 1 User image Atte Kemppilä [:atte] 2012-06-25 11:29:47 PDT
Created attachment 636409 [details] [diff] [review]
Comment 2 User image Neil Deakin 2012-06-25 12:21:37 PDT
Thanks for the patch. Do you need help to check it in?
Comment 3 User image Atte Kemppilä [:atte] 2012-06-25 12:33:59 PDT
Yeah, I have no idea how checking is done.
Comment 4 User image Neil Deakin 2012-06-26 06:57:11 PDT
If you set the 'checkin-needed' keyword on the bug, as I've done, someone may come along and check it in. If not, you can ask on the #developers irc channel for someone to.
Comment 5 User image Jared Wein [:jaws] (please needinfo? me) 2012-06-26 15:46:00 PDT
Pushed to mozilla-inbound:

Nice job on your first patch Atte. If everything goes smoothly, your patch will be merged to mozilla-central within a day or two.
Comment 6 User image Ed Morley [:emorley] 2012-06-27 03:34:46 PDT

Note You need to log in before you can comment on or make changes to this bug.