Note: There are a few cases of duplicates in user autocompletion which are being worked on.

XBL for menu-button inherits accessKey instead of accesskey

RESOLVED FIXED in mozilla16

Status

()

Core
XUL
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Daniel Dawson, Assigned: atte)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.12 KB, patch
Neil Deakin (not available until Aug 9)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
The content button in the XBL at chrome://global/content/bindings/button.xml#menu-button has "accessKey" (uppercase "K") in its inherits list. But this should be "accesskey" (lowercase). This usually results in the accesskey not being underlined, although the key still activates the button. Also, if the accesskey comes from a command element, it becomes underlined on mouseover.
(Assignee)

Comment 1

5 years ago
Created attachment 636409 [details] [diff] [review]
patch
Attachment #636409 - Flags: review?(enndeakin)
Attachment #636409 - Flags: review?(enndeakin) → review+
Thanks for the patch. Do you need help to check it in?
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 3

5 years ago
Yeah, I have no idea how checking is done.
If you set the 'checkin-needed' keyword on the bug, as I've done, someone may come along and check it in. If not, you can ask on the #developers irc channel for someone to.
Keywords: checkin-needed
Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ee8a6148b94

Nice job on your first patch Atte. If everything goes smoothly, your patch will be merged to mozilla-central within a day or two.
Assignee: nobody → atte.kemppila
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla16

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/2ee8a6148b94
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.