745755 - Generate a marketplace bookmark on profile creation?

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

http://mxr.mozilla.org/mozilla-central/source/mobile/locales/generic/profile/bookmarks.json.in

Would it make sense to generate a marketplace bookmark on new profile creation considering there is one for AMO?

--
title: Mozilla Marketplace
icon: http://mxr.mozilla.org/mozilla-central/source/mobile/locales/generic/profile/bookmarks.json.in#10
URI: http://marketplace.mozilla.org
--

Comment 1

[Aaron Train [:aaronmt]]

Soft-release blocker for Mozilla Marketplace discoverability?

Comment 2

[Asa Dotzler [:asa]]

nice to have at best.

Comment 3

[:Margaret Leibovic]

We're going to do this now.

Comment 4

[:Margaret Leibovic]

Attachment: add marketplace bookmark

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8366833 [details] [diff] [review]
add marketplace bookmark

Review of attachment 8366833 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/strings.xml.in
@@ +309,5 @@
>    <string name="bookmarkdefaults_url_support">http://support.mozilla.org/@AB_CD@/products/mobile</string>
>    <string name="bookmarkdefaults_favicon_abouthome">chrome/chrome/content/branding/favicon64.png</string>
>  
> +  <string name="bookmarkdefaults_title_marketplace">@bookmarks_marketplace@</string>
> +  <string name="bookmarkdefaults_url_marketplace">https://marketplace.firefox.com/</string>

It might be nice to add a comment that the favicon will automatically come from the marketplace.png drawable.

Comment 6

[:Margaret Leibovic]

This was green on try:
https://tbpl.mozilla.org/?tree=Try&rev=fa62d24db724

Added some more comments to explain the "magic":
https://hg.mozilla.org/integration/fx-team/rev/dc13e23057af

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dc13e23057af