Closed Bug 745755 Opened 8 years ago Closed 6 years ago

Generate a marketplace bookmark on profile creation?

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 29
blocking-kilimanjaro -
Tracking Status
firefox29 --- verified
blocking-fennec1.0 --- -

People

(Reporter: aaronmt, Assigned: Margaret)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/mobile/locales/generic/profile/bookmarks.json.in

Would it make sense to generate a marketplace bookmark on new profile creation considering there is one for AMO?

--
title: Mozilla Marketplace
icon: http://mxr.mozilla.org/mozilla-central/source/mobile/locales/generic/profile/bookmarks.json.in#10
URI: http://marketplace.mozilla.org
--
Component: Web Apps → General
QA Contact: web-apps → general
Soft-release blocker for Mozilla Marketplace discoverability?
blocking-fennec1.0: --- → ?
blocking-fennec1.0: ? → -
blocking-kilimanjaro: --- → ?
nice to have at best.
blocking-kilimanjaro: ? → -
We're going to do this now.
Assignee: nobody → margaret.leibovic
Attachment #8366833 - Flags: review?(wjohnston)
Comment on attachment 8366833 [details] [diff] [review]
add marketplace bookmark

Review of attachment 8366833 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/strings.xml.in
@@ +309,5 @@
>    <string name="bookmarkdefaults_url_support">http://support.mozilla.org/@AB_CD@/products/mobile</string>
>    <string name="bookmarkdefaults_favicon_abouthome">chrome/chrome/content/branding/favicon64.png</string>
>  
> +  <string name="bookmarkdefaults_title_marketplace">@bookmarks_marketplace@</string>
> +  <string name="bookmarkdefaults_url_marketplace">https://marketplace.firefox.com/</string>

It might be nice to add a comment that the favicon will automatically come from the marketplace.png drawable.
Attachment #8366833 - Flags: review?(wjohnston) → review+
This was green on try:
https://tbpl.mozilla.org/?tree=Try&rev=fa62d24db724

Added some more comments to explain the "magic":
https://hg.mozilla.org/integration/fx-team/rev/dc13e23057af
https://hg.mozilla.org/mozilla-central/rev/dc13e23057af
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.