Closed
Bug 745762
Opened 12 years ago
Closed 12 years ago
double-conversion.h fails to compile on mingw
Categories
(Core :: MFBT, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.83 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
GCC doesn't like mixing dllexport/dllimport with inline implementation of class functions. It's safe to drop MFTB_API for such functions (other similar functions already do so).
Attachment #615342 -
Flags: review?(jwalden+bmo)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 615342 [details] [diff] [review] fix v1.0 Review of attachment 615342 [details] [diff] [review]: ----------------------------------------------------------------- Any changes we make to this code need to be properly integrated into mfbt/double-conversion/update.sh, please -- too easy for the code to become irreparably forked otherwise. Please do that, then request review. Thanks!
Attachment #615342 -
Flags: review?(jwalden+bmo) → review-
|
Assignee | |
Comment 2•12 years ago
|
||
Oh, I missed the fact that it's imported this way. The attached patch fixes existing patch that adds MFTB_API. Verified by re-importing locally. I've also fixed update.sh script to use proper patch file name.
Attachment #615342 -
Attachment is obsolete: true
Attachment #615637 -
Flags: review?(jwalden+bmo)
|
|
||
Updated•12 years ago
|
Attachment #615637 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Thanks for the review. https://hg.mozilla.org/integration/mozilla-inbound/rev/546445acceae
Target Milestone: --- → mozilla15
|
||
Comment 4•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/546445acceae
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•