double-conversion.h fails to compile on mingw

RESOLVED FIXED in mozilla15

Status

()

Core
MFBT
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla15
x86
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

3.83 KB, patch
Waldo
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 615342 [details] [diff] [review]
fix v1.0

GCC doesn't like mixing dllexport/dllimport with inline implementation of class functions. It's safe to drop MFTB_API for such functions (other similar functions already do so).
Attachment #615342 - Flags: review?(jwalden+bmo)
Comment on attachment 615342 [details] [diff] [review]
fix v1.0

Review of attachment 615342 [details] [diff] [review]:
-----------------------------------------------------------------

Any changes we make to this code need to be properly integrated into mfbt/double-conversion/update.sh, please -- too easy for the code to become irreparably forked otherwise.  Please do that, then request review.  Thanks!
Attachment #615342 - Flags: review?(jwalden+bmo) → review-
(Assignee)

Comment 2

5 years ago
Created attachment 615637 [details] [diff] [review]
fix v1.1

Oh, I missed the fact that it's imported this way. The attached patch fixes existing patch that adds MFTB_API. Verified by re-importing locally. I've also fixed update.sh script to use proper patch file name.
Attachment #615342 - Attachment is obsolete: true
Attachment #615637 - Flags: review?(jwalden+bmo)
Attachment #615637 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 3

5 years ago
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/546445acceae
Target Milestone: --- → mozilla15
http://hg.mozilla.org/mozilla-central/rev/546445acceae
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.