Closed
Bug 745899
Opened 12 years ago
Closed 12 years ago
Add support in Nullable for sanely dealing with |sequence<T>?| types
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
938 bytes,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
If sequence<T> becomes nsTArray<T>, then sequence<T>? should become Nullable< nsTArray<T> >. But then setting it to a non-null value involves an array copy, with the existing SetValue() API. The proposal is to add a SetValue (or PrepareToSetValue?) that returns a T& that can then be written to.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #615434 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [need review]
|
||
Updated•12 years ago
|
Attachment #615434 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/eb21c40c5be2
Flags: in-testsuite-
Whiteboard: [need review] → [need birch merge]
Target Milestone: --- → mozilla15
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eb21c40c5be2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [need birch merge]
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•