Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add support in Nullable for sanely dealing with |sequence<T>?| types

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
If sequence<T> becomes nsTArray<T>, then sequence<T>? should become
Nullable< nsTArray<T> >.  But then setting it to a non-null value involves an array copy, with the existing SetValue() API.

The proposal is to add a SetValue (or PrepareToSetValue?) that returns a T& that can then be written to.
(Assignee)

Comment 1

5 years ago
Created attachment 615434 [details] [diff] [review]
Make it easier to use Nullable for non-primitive types.
Attachment #615434 - Flags: review?(peterv)
(Assignee)

Updated

5 years ago
Whiteboard: [need review]
Attachment #615434 - Flags: review?(peterv) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/projects/birch/rev/eb21c40c5be2
Flags: in-testsuite-
Whiteboard: [need review] → [need birch merge]
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/eb21c40c5be2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [need birch merge]
You need to log in before you can comment on or make changes to this bug.