Closed
Bug 745904
Opened 13 years ago
Closed 13 years ago
GCLI needs extra unit tests for recently added code
Categories
(DevTools :: Console, defect, P2)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: jwalker, Assigned: jwalker)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 1 obsolete file)
|
61.79 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
Specifically to answer https://github.com/campd/gcli/pull/31#commitcomment-1208061
|
Assignee | |
Updated•13 years ago
|
Target Milestone: --- → Firefox 15
|
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
a.k.a https://github.com/campd/gcli/pull/32 (with the 2 extra commits)
|
|
Assignee | |
Comment 3•13 years ago
|
||
I'm not sure if we worry about file permissions - the previous patch had some files set to 755 rather than 644. This fixes that.
Attachment #623119 -
Attachment is obsolete: true
Attachment #623119 -
Flags: review?(dcamp)
Attachment #623223 -
Flags: review?(dcamp)
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Updated•13 years ago
|
Attachment #623223 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Try before land:
https://tbpl.mozilla.org/?tree=Try&rev=eba127ab7962
Fx-Team:
https://tbpl.mozilla.org/?tree=Fx-Team&rev=0f08ab4dfcac
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•