Last Comment Bug 745991 - nsCSSFrameConstructor.cpp:8973:64: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
: nsCSSFrameConstructor.cpp:8973:64: warning: suggest parentheses around ‘&&’ w...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Daniel Holbert [:dholbert]
:
:
Mentors:
Depends on:
Blocks: buildwarning 718236
  Show dependency treegraph
 
Reported: 2012-04-16 15:43 PDT by Daniel Holbert [:dholbert]
Modified: 2012-04-17 18:27 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1 (1.34 KB, patch)
2012-04-16 15:47 PDT, Daniel Holbert [:dholbert]
smontagu: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2012-04-16 15:43:57 PDT
nsCSSFrameConstructor.cpp is nearly gcc-warning-free -- just has this one warning:
{
nsCSSFrameConstructor.cpp: In member function ‘bool nsCSSFrameConstructor::MaybeRecreateContainerForFrameRemoval(nsIFrame*, nsresult*)’:
nsCSSFrameConstructor.cpp:8973:64: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]

}
for a block of code added in http://hg.mozilla.org/mozilla-central/rev/33b309643e39 (bug 718236)

Simple enough to fix.
Comment 1 Daniel Holbert [:dholbert] 2012-04-16 15:47:07 PDT
Created attachment 615512 [details] [diff] [review]
fix v1
Comment 2 Simon Montagu :smontagu 2012-04-16 22:30:51 PDT
Comment on attachment 615512 [details] [diff] [review]
fix v1

Review of attachment 615512 [details] [diff] [review]:
-----------------------------------------------------------------

I have never agreed with that warning, but OK (and a straw poll on IRC indicates that it's only me who thinks so)
Comment 3 Daniel Holbert [:dholbert] 2012-04-17 09:58:47 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/c79838793ceb
Comment 4 Ed Morley [:emorley] 2012-04-17 18:27:45 PDT
https://hg.mozilla.org/mozilla-central/rev/c79838793ceb

Note You need to log in before you can comment on or make changes to this bug.