Closed
Bug 745991
Opened 13 years ago
Closed 13 years ago
nsCSSFrameConstructor.cpp:8973:64: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.34 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
nsCSSFrameConstructor.cpp is nearly gcc-warning-free -- just has this one warning:
{
nsCSSFrameConstructor.cpp: In member function ‘bool nsCSSFrameConstructor::MaybeRecreateContainerForFrameRemoval(nsIFrame*, nsresult*)’:
nsCSSFrameConstructor.cpp:8973:64: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
}
for a block of code added in http://hg.mozilla.org/mozilla-central/rev/33b309643e39 (bug 718236)
Simple enough to fix.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #615512 -
Flags: review?
|
|
Assignee | |
Updated•13 years ago
|
Attachment #615512 -
Flags: review? → review?(smontagu)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 615512 [details] [diff] [review]
fix v1
Review of attachment 615512 [details] [diff] [review]:
-----------------------------------------------------------------
I have never agreed with that warning, but OK (and a straw poll on IRC indicates that it's only me who thinks so)
Attachment #615512 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla14
|
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•