nsCSSFrameConstructor.cpp:8973:64: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]

RESOLVED FIXED in mozilla14

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
nsCSSFrameConstructor.cpp is nearly gcc-warning-free -- just has this one warning:
{
nsCSSFrameConstructor.cpp: In member function ‘bool nsCSSFrameConstructor::MaybeRecreateContainerForFrameRemoval(nsIFrame*, nsresult*)’:
nsCSSFrameConstructor.cpp:8973:64: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]

}
for a block of code added in http://hg.mozilla.org/mozilla-central/rev/33b309643e39 (bug 718236)

Simple enough to fix.
(Assignee)

Comment 1

5 years ago
Created attachment 615512 [details] [diff] [review]
fix v1
Attachment #615512 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #615512 - Flags: review? → review?(smontagu)
Comment on attachment 615512 [details] [diff] [review]
fix v1

Review of attachment 615512 [details] [diff] [review]:
-----------------------------------------------------------------

I have never agreed with that warning, but OK (and a straw poll on IRC indicates that it's only me who thinks so)
Attachment #615512 - Flags: review?(smontagu) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c79838793ceb
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/c79838793ceb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.