Closed
Bug 745993
Opened 13 years ago
Closed 13 years ago
Fix failing test from bug 708175
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: jwir3, Assigned: jwir3)
References
Details
Attachments
(1 file)
|
2.92 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
There was a mistake in the checkin for bug 708175 that caused a test to not be run correctly, leading to a checked-in failing test, which is currently commented-out.
See bug 708175, comment 43.
| Assignee | ||
Comment 1•13 years ago
|
||
The reference file should have had font-size equal to 34, not 12.
Attachment #615518 -
Flags: review?(dbaron)
Comment on attachment 615518 [details] [diff] [review]
b745993
r=dbaron, though against a current mozilla-inbound tree the reftest.list change should look like uncommenting a line. (Don't try landing on central, because then you'll leave the inbound-central merger to deal with the mess.)
Attachment #615518 -
Flags: review?(dbaron) → review+
| Assignee | ||
Comment 3•13 years ago
|
||
(In reply to David Baron [:dbaron] from comment #2)
> Comment on attachment 615518 [details] [diff] [review]
> b745993
>
> r=dbaron, though against a current mozilla-inbound tree the reftest.list
> change should look like uncommenting a line. (Don't try landing on central,
> because then you'll leave the inbound-central merger to deal with the mess.)
Yup, I had planned on merging locally with m-i before pushing back up to inbound.
| Assignee | ||
Comment 4•13 years ago
|
||
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e11f5d4b7d9
Status: NEW → UNCONFIRMED
Ever confirmed: false
Target Milestone: --- → mozilla14
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•