746021 - browser_webconsole_bug_603750_websocket.js breaks with compartment-per-global

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Bobby Holley (:bholley)]

We assert that the window IDs for two WebSockets errors are the same:

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/test/browser_webconsole_bug_603750_websocket.js#33

However, the sockets are created in different scopes:
http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/test/test-bug-603750-websocket.js

This means that the code that throws is running against a different global in the iframe case for compartment-per-global. It's not clear to me why we assert this, so I'm removing it.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Don't assert that the window ids are the same when they shouldn't be. v1

Attaching a patch. Flagging msucan for review.

Comment 2

[Bobby Holley (:bholley)]

For context, the window id is coming from here:

http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsWebSocket.cpp#1571

which uses:

http://mxr.mozilla.org/mozilla-central/source/dom/base/nsJSUtils.cpp#170

Comment 3

[Mihai Sucan [:msucan]]

Comment on attachment 615569 [details] [diff] [review]
Don't assert that the window ids are the same when they shouldn't be. v1

Review of attachment 615569 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. Thank you!

Comment 4

[Bobby Holley (:bholley)]

Pushed to m-i: http://hg.mozilla.org/integration/mozilla-inbound/rev/a0ecc336b66d

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a0ecc336b66d