746086 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoApp.onApplicationPause(GeckoApp.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There are two crashes from the same user, the last one is bp-4df69c9b-919c-4b93-b5d6-75d192120416.

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoApp.onApplicationPause(GeckoApp.java:2135)
	at org.mozilla.gecko.GeckoApplication.onActivityPause(GeckoApplication.java:43)
	at org.mozilla.gecko.GeckoActivity.onPause(GeckoActivity.java:24)
	at android.app.Activity.performPause(Activity.java:4563)
	at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1195)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1999)
	at android.app.ActivityThread.access$600(ActivityThread.java:122)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1146)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4340)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.GeckoApp.onApplicationPause%28GeckoApp.java%29

Comment 1

[Scoobidiver (away)]

There's a spike in crashes starting in 14.0a1/20120421030642. The regression range for the spike is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=22bfdebf5cae&tochange=021f95903ded

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - can you look and see what might be causing this?

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Is there any steps to reproduce?

The likelihood of this crashing is when Fennec is starting and before initializing, the activity goes to background. This is when mConnectivityReceiver wouldn't have been initialized.

This patch tries to register/unregister only when mConnectivityReceiver is not null.

This might fix the issue, as that's the only variable that could trigger a NPE there.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 617601 [details] [diff] [review]
Patch

Looks OK. Since we have no STR, but this is a topcrash, we should land this and see what affect it has on crash-stats.

Comment 5

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e84141c374c2

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e84141c374c2

Comment 7

[Cristian Nicolae (:xti)]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Comment on attachment 617601 [details] [diff] [review]
> Patch
> 
> Looks OK. Since we have no STR, but this is a topcrash, we should land this
> and see what affect it has on crash-stats.

Since we don't have any STR here and it doesn't occur so far, shall we close it as verified fixed?

Comment 8

[Scoobidiver (away)]

The latest crashes happened in 14.0a1/20120423.