746089 - closing a thread removes it from all listings

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P4)

Description

[Kadir Topal [:atopal]]

Apparently a side effect of a recent change was that closed threads are immeditately removed from all /question listings (and possibly search results).

Please change that back, so closing threads has no further effect.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

See bug 708843. I think I may have gone to far and removed locked questions from all listings not only the no-replies list. Do we still want to keep them out of the no-replies list?

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

This should probably be a P1. Seems like a big issue.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

We are waiting on some (community and sumo team) feedback before going forward with this.

Comment 4

[Alice Wyman]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #3)
> We are waiting on some (community and sumo team) feedback before going
> forward with this.

Who are you waiting on?  Related discussion:
https://support.mozilla.org/forums/contributors/708326#post-46368

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Alice Wyman from comment #4)
> Who are you waiting on?  Related discussion:
> https://support.mozilla.org/forums/contributors/708326#post-46368

There are some scenarios in which hiding the locked questions makes sense. For example, they shouldn't show up in the No Replies view because if you click on one to reply there is nothing you can do anyway. Although I am wondering if it is better to just delete the question in that case?

What is locking used for anyway? :-)

Comment 6

[Alice Wyman]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #5)
> 
> What is locking used for anyway? :-)
If we come across a thread that is old (over 6 months for instance) it should be locked so that new replies aren't posted. There is a long discussion on locking old threads at 
https://support.mozilla.org/forums/contributors/708115

Threads that are solved can get off-topic with additional replies, so those might be locked but you still want them to be findable.  I also lock threads that are linked from Navigation articles such as https://support.mozilla.org/kb/fix-problems-your-home-page-or-search to prevent new posts. Another reason to lock a thread would be if it's a duplicate (two identical threads posted 15 minutes apart, for example) but the duplicate thread should be OK to hide, I suppose.

Comment 7

[Kadir Topal [:atopal]]

Okay, let's move on, and only remove locked threads from the view "no replies" and the new "questions with no replies in the last 3 days" view.

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Have a pull request for this:

https://github.com/mozilla/kitsune/pull/594

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

And this closes our .8 sprint \o/

https://github.com/mozilla/kitsune/commit/3d2ffaf149832d777dc5169ed3d962f0ac0daea4