Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Updating the DirectoryProvider to look for user.js in /data/local on B2G phones

RESOLVED FIXED in DeveloperPhone

Status

Firefox OS
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: etienne, Assigned: etienne)

Tracking

unspecified
DeveloperPhone
All
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We're already doing this of the OfflineCache and webapps dir.

This allows us to put everything in place when doing a make install-gaia even if the profile dir isn't created yet (on a first install).

The user.js is generated by the Gaia makefile based on the various app manifests.
(Assignee)

Comment 1

5 years ago
Created attachment 615693 [details] [diff] [review]
Patch proposal
Assignee: nobody → etienne
(Assignee)

Updated

5 years ago
Attachment #615693 - Flags: review?(21)
Can you rename OFFLINE_PROFILE_DIR to LOCAL_DIR. It seems like everybody use it and it does not make sense to keep the name as if.

Can you test your change with |GAIA_DOMAIN=localhost.org make && GAIA_DOMAIN=locahost.org make install-gaia| on the device and see if it works?
(Assignee)

Comment 3

5 years ago
Created attachment 615721 [details] [diff] [review]
Patch v2
Attachment #615693 - Attachment is obsolete: true
Attachment #615693 - Flags: review?(21)
Attachment #615721 - Flags: review?(21)
(Assignee)

Comment 4

5 years ago
(In reply to Vivien Nicolas (:vingtetun) from comment #2)
> Can you test your change with |GAIA_DOMAIN=localhost.org make &&
> GAIA_DOMAIN=locahost.org make install-gaia| on the device and see if it
> works?

Yes it works!
Comment on attachment 615721 [details] [diff] [review]
Patch v2

Nice, thanks.
Attachment #615721 - Flags: review?(21) → review+
Good idea!
Comment on attachment 615721 [details] [diff] [review]
Patch v2

Review of attachment 615721 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/DirectoryProvider.js
@@ +21,5 @@
>    QueryInterface: XPCOMUtils.generateQI([Ci.nsIDirectoryServiceProvider]),
>  
>    getFile: function dp_getFile(prop, persistent) {
>  #ifdef MOZ_WIDGET_GONK
> +    let localProps = ["cachePDir", "webappsDir", "PrefD"];

Did you mean "ProfD"?
(Assignee)

Comment 8

5 years ago
(In reply to Philipp von Weitershausen [:philikon] from comment #7)
> Comment on attachment 615721 [details] [diff] [review]
> Patch v2
> 
> Review of attachment 615721 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: b2g/components/DirectoryProvider.js
> @@ +21,5 @@
> >    QueryInterface: XPCOMUtils.generateQI([Ci.nsIDirectoryServiceProvider]),
> >  
> >    getFile: function dp_getFile(prop, persistent) {
> >  #ifdef MOZ_WIDGET_GONK
> > +    let localProps = ["cachePDir", "webappsDir", "PrefD"];
> 
> Did you mean "ProfD"?

Don't think so:
http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsAppDirectoryServiceDefs.h#96
https://hg.mozilla.org/integration/mozilla-inbound/rev/70689bad7156
Status: NEW → ASSIGNED
Target Milestone: --- → DeveloperPhone
https://hg.mozilla.org/mozilla-central/rev/70689bad7156
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.