Failure for the shortcut keys in actions/test_keys.html b/accessible/tests/mochitest/actions/test_keys.html

REOPENED
Assigned to

Status

()

Core
Disability Access APIs
REOPENED
6 years ago
6 years ago

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Tracking

(Blocks: 1 bug)

Trunk
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Log file says:
255 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/actions/test_keys.html | Wrong keyboard shortcut on  'input2'  - got %b, expected b
256 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/actions/test_keys.html | Wrong keyboard shortcut on  'link'  - got %l, expected l
(Assignee)

Comment 1

6 years ago
Created attachment 615727 [details] [diff] [review]
Fix
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Attachment #615727 - Flags: review?(surkov.alexander)

Comment 2

6 years ago
Comment on attachment 615727 [details] [diff] [review]
Fix

Review of attachment 615727 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/actions/test_keys.html
@@ +26,5 @@
>      function doTest()
>      {
>        testKeyboardShortcut("input1", "");
> +      testKeyboardShortcut("input2", MAC ? "⌃%b" : "Alt+Shift+b");
> +      testKeyboardShortcut("link", MAC ? "⌃%l" : "Alt+Shift+l");

interesting, there's no '^' in report: "got %b, expected b"
Attachment #615727 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/cefa04404a30
Target Milestone: --- → mozilla14

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/cefa04404a30
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

6 years ago
Created attachment 618290 [details] [diff] [review]
Proper character for Option key, the one in the previous patch was wrong.
Attachment #618290 - Flags: review?(hub)
reopening
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 618290 [details] [diff] [review]
Proper character for Option key, the one in the previous patch was wrong.

Review of attachment 618290 [details] [diff] [review]:
-----------------------------------------------------------------

tested. works.
Attachment #618290 - Flags: review?(hub) → review+
(Assignee)

Comment 8

6 years ago
Proper fix on inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/5b623170c1d4
Target Milestone: mozilla14 → mozilla15

Comment 9

6 years ago
(In reply to Marco Zehe (:MarcoZ) from comment #8)
> Proper fix on inbound:
> http://hg.mozilla.org/integration/mozilla-inbound/rev/5b623170c1d4

Sorry, push backed out for linux mochitest-other orange:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&onlyunstarred=1&rev=8cc13f37bc66
https://tbpl.mozilla.org/php/getParsedLog.php?id=11222399&tree=Mozilla-Inbound

{
4512 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/events/test_focus_listcontrols.xul | Error in test: proposed current item 'ml_tangerine' is already current
}

https://hg.mozilla.org/integration/mozilla-inbound/rev/922510fc28aa
Target Milestone: mozilla15 → ---
You need to log in before you can comment on or make changes to this bug.