746168 - Wrong font referenced in attributes/test_text.html for the cursive test

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

It appears that Mac OS X Lion is also using Comic Sans MS like Windows does. Log file entry:

2435 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/attributes/test_text.html | Attribute 'font-family' has wrong value for area16 at offset 27 - got Comic Sans MS, expected MacFont

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Fix

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 615729 [details] [diff] [review]
Fix

Review of attachment 615729 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/attributes.js
@@ +236,5 @@
>    function(aFontFamily) { return aFontFamily != "sans-serif"; }
>  const kSerifFontFamily =
>    function(aFontFamily) { return aFontFamily != "serif"; }
>  
> +const kCursiveFontFamily = LINUX ? "DejaVu Serif" : "Comic Sans MS";

I hope it works on any platform, otherwise you need to do something like we do above

Comment 3

[alexander :surkov (:asurkov)]

(In reply to alexander :surkov from comment #2)

> I hope it works on any platform, otherwise you need to do something like we
> do above

I meant machine. Perhaps fonts are vary from OS X to OS X.

Comment 4

[Marco Zehe (:MarcoZ)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f636d62d5920

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f636d62d5920