Closed Bug 746168 Opened 11 years ago Closed 11 years ago

Wrong font referenced in attributes/test_text.html for the cursive test

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14
Project Flags:
Performance Impact fixed
Webcompat Priority fixed
a11y-review fixed
Tracking Flags:
Tracking Status
relnote-firefox --- fixed
thunderbird_esr91 fixed fixed
thunderbird_esr102 fixed fixed
firefox-esr102 fixed fixed
firefox111 fixed fixed
firefox112 fixed fixed
firefox113 fixed fixed

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Fix
844 bytes, patch
surkov
: review+
Details | Diff | Splinter Review 
It appears that Mac OS X Lion is also using Comic Sans MS like Windows does. Log file entry:

2435 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/attributes/test_text.html | Attribute 'font-family' has wrong value for area16 at offset 27 - got Comic Sans MS, expected MacFont
Attached patch Fix — — Splinter Review 
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED

        Attachment #615729 -
        Flags: review?(surkov.alexander)

    
    

    
  
Comment on attachment 615729 [details] [diff] [review]
Fix

Review of attachment 615729 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/attributes.js
@@ +236,5 @@
>    function(aFontFamily) { return aFontFamily != "sans-serif"; }
>  const kSerifFontFamily =
>    function(aFontFamily) { return aFontFamily != "serif"; }
>  
> +const kCursiveFontFamily = LINUX ? "DejaVu Serif" : "Comic Sans MS";

I hope it works on any platform, otherwise you need to do something like we do above

        Attachment #615729 -
        Flags: review?(surkov.alexander) → review+

    
    

    
  
(In reply to alexander :surkov from comment #2)

> I hope it works on any platform, otherwise you need to do something like we
> do above

I meant machine. Perhaps fonts are vary from OS X to OS X.

    
  
Target Milestone: --- → mozilla14

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f636d62d5920
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.