Last Comment Bug 746168 - Wrong font referenced in attributes/test_text.html for the cursive test
: Wrong font referenced in attributes/test_text.html for the cursive test
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- normal (vote)
: mozilla14
Assigned To: Marco Zehe (:MarcoZ)
:
:
Mentors:
Depends on:
Blocks: 746160
  Show dependency treegraph
 
Reported: 2012-04-17 08:39 PDT by Marco Zehe (:MarcoZ)
Modified: 2012-04-17 18:29 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (844 bytes, patch)
2012-04-17 08:41 PDT, Marco Zehe (:MarcoZ)
surkov.alexander: review+
Details | Diff | Splinter Review

Description Marco Zehe (:MarcoZ) 2012-04-17 08:39:16 PDT
It appears that Mac OS X Lion is also using Comic Sans MS like Windows does. Log file entry:

2435 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/attributes/test_text.html | Attribute 'font-family' has wrong value for area16 at offset 27 - got Comic Sans MS, expected MacFont
Comment 1 Marco Zehe (:MarcoZ) 2012-04-17 08:41:02 PDT
Created attachment 615729 [details] [diff] [review]
Fix
Comment 2 alexander :surkov 2012-04-17 08:45:30 PDT
Comment on attachment 615729 [details] [diff] [review]
Fix

Review of attachment 615729 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/attributes.js
@@ +236,5 @@
>    function(aFontFamily) { return aFontFamily != "sans-serif"; }
>  const kSerifFontFamily =
>    function(aFontFamily) { return aFontFamily != "serif"; }
>  
> +const kCursiveFontFamily = LINUX ? "DejaVu Serif" : "Comic Sans MS";

I hope it works on any platform, otherwise you need to do something like we do above
Comment 3 alexander :surkov 2012-04-17 09:06:17 PDT
(In reply to alexander :surkov from comment #2)

> I hope it works on any platform, otherwise you need to do something like we
> do above

I meant machine. Perhaps fonts are vary from OS X to OS X.
Comment 5 Ed Morley [:emorley] 2012-04-17 18:29:17 PDT
https://hg.mozilla.org/mozilla-central/rev/f636d62d5920

Note You need to log in before you can comment on or make changes to this bug.