Wrong font referenced in attributes/test_text.html for the cursive test

RESOLVED FIXED in mozilla14

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
It appears that Mac OS X Lion is also using Comic Sans MS like Windows does. Log file entry:

2435 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/attributes/test_text.html | Attribute 'font-family' has wrong value for area16 at offset 27 - got Comic Sans MS, expected MacFont
(Assignee)

Comment 1

5 years ago
Created attachment 615729 [details] [diff] [review]
Fix
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Attachment #615729 - Flags: review?(surkov.alexander)

Comment 2

5 years ago
Comment on attachment 615729 [details] [diff] [review]
Fix

Review of attachment 615729 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/attributes.js
@@ +236,5 @@
>    function(aFontFamily) { return aFontFamily != "sans-serif"; }
>  const kSerifFontFamily =
>    function(aFontFamily) { return aFontFamily != "serif"; }
>  
> +const kCursiveFontFamily = LINUX ? "DejaVu Serif" : "Comic Sans MS";

I hope it works on any platform, otherwise you need to do something like we do above
Attachment #615729 - Flags: review?(surkov.alexander) → review+

Comment 3

5 years ago
(In reply to alexander :surkov from comment #2)

> I hope it works on any platform, otherwise you need to do something like we
> do above

I meant machine. Perhaps fonts are vary from OS X to OS X.
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/f636d62d5920
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla14

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f636d62d5920
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.