Closed
Bug 746168
Opened 13 years ago
Closed 13 years ago
Wrong font referenced in attributes/test_text.html for the cursive test
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
844 bytes,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
It appears that Mac OS X Lion is also using Comic Sans MS like Windows does. Log file entry:
2435 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/attributes/test_text.html | Attribute 'font-family' has wrong value for area16 at offset 27 - got Comic Sans MS, expected MacFont
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Attachment #615729 -
Flags: review?(surkov.alexander)
Comment 2•13 years ago
|
||
Comment on attachment 615729 [details] [diff] [review]
Fix
Review of attachment 615729 [details] [diff] [review]:
-----------------------------------------------------------------
::: accessible/tests/mochitest/attributes.js
@@ +236,5 @@
> function(aFontFamily) { return aFontFamily != "sans-serif"; }
> const kSerifFontFamily =
> function(aFontFamily) { return aFontFamily != "serif"; }
>
> +const kCursiveFontFamily = LINUX ? "DejaVu Serif" : "Comic Sans MS";
I hope it works on any platform, otherwise you need to do something like we do above
Attachment #615729 -
Flags: review?(surkov.alexander) → review+
Comment 3•13 years ago
|
||
(In reply to alexander :surkov from comment #2)
> I hope it works on any platform, otherwise you need to do something like we
> do above
I meant machine. Perhaps fonts are vary from OS X to OS X.
Assignee | ||
Comment 4•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Target Milestone: --- → mozilla14
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•