746228 - pack JSPropertyDescriptor better on 64-bit hosts

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nathan Froyd [:froydnj]]

JSProperty descriptor is currently laid out like so:

    JSObject           *obj;
    unsigned              attrs;
    JSPropertyOp       getter;
    JSStrictPropertyOp setter;
    jsval              value;
    unsigned              shortid;

which on 64-bit platforms introduces eight bytes of padding: four after each unsigned member.

The fields should be reordered to eliminate said padding.  Patch coming up.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 615782 [details] [diff] [review]
patch

Could you fix the alignment of attrs and shortid?  These are some style casualties from the recent removal of uintN.

Comment 3

[Nathan Froyd [:froydnj]]

http://hg.mozilla.org/projects/birch/rev/636b1b09842e

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/636b1b09842e