The default bug view has changed. See this FAQ.

pack JSPropertyDescriptor better on 64-bit hosts

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
JSProperty descriptor is currently laid out like so:

    JSObject           *obj;
    unsigned              attrs;
    JSPropertyOp       getter;
    JSStrictPropertyOp setter;
    jsval              value;
    unsigned              shortid;

which on 64-bit platforms introduces eight bytes of padding: four after each unsigned member.

The fields should be reordered to eliminate said padding.  Patch coming up.
(Assignee)

Comment 1

5 years ago
Created attachment 615782 [details] [diff] [review]
patch
Attachment #615782 - Flags: review?(luke)

Comment 2

5 years ago
Comment on attachment 615782 [details] [diff] [review]
patch

Could you fix the alignment of attrs and shortid?  These are some style casualties from the recent removal of uintN.
Attachment #615782 - Flags: review?(luke) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/projects/birch/rev/636b1b09842e
Assignee: general → nfroyd
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/636b1b09842e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.