Closed
Bug 746279
Opened 13 years ago
Closed 13 years ago
pack nsFont more carefully
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
nsFont is currently laid out like so:
nsString name;
PRUint8 style;
PRUint8 systemFont;
PRUint8 variant;
PRUint16 weight;
PRInt16 stretch;
PRUint8 decorations;
nscoord size;
// ...plus a bit more.
This layout introduces holes after 'decorations' and 'variant' or 'stretch', depending on the wordsize of the machine. This can be fixed rather easily by moving 'decorations' after 'variant', which nicely plugs the hole(s) everywhere.
Attachment #615825 -
Flags: review?(jdaggett)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 615825 [details] [diff] [review]
patch
Sure, looks reasonable.
Attachment #615825 -
Flags: review?(jdaggett) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•