746279 - pack nsFont more carefully

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Nathan Froyd [:froydnj]]

Attachment: patch

nsFont is currently laid out like so:

  nsString name;
  PRUint8 style;
  PRUint8 systemFont;
  PRUint8 variant;
  PRUint16 weight;
  PRInt16 stretch;
  PRUint8 decorations;
  nscoord size;
  // ...plus a bit more.

This layout introduces holes after 'decorations' and 'variant' or 'stretch', depending on the wordsize of the machine.  This can be fixed rather easily by moving 'decorations' after 'variant', which nicely plugs the hole(s) everywhere.

Comment 1

[John Daggett (:jtd)]

Comment on attachment 615825 [details] [diff] [review]
patch

Sure, looks reasonable.

Comment 2

[Nathan Froyd [:froydnj]]

http://hg.mozilla.org/projects/birch/rev/7c9665fc65c8

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/7c9665fc65c8