Note: There are a few cases of duplicates in user autocompletion which are being worked on.

pack nsFont more carefully

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics: Text
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 615825 [details] [diff] [review]
patch

nsFont is currently laid out like so:

  nsString name;
  PRUint8 style;
  PRUint8 systemFont;
  PRUint8 variant;
  PRUint16 weight;
  PRInt16 stretch;
  PRUint8 decorations;
  nscoord size;
  // ...plus a bit more.

This layout introduces holes after 'decorations' and 'variant' or 'stretch', depending on the wordsize of the machine.  This can be fixed rather easily by moving 'decorations' after 'variant', which nicely plugs the hole(s) everywhere.
Attachment #615825 - Flags: review?(jdaggett)

Comment 1

5 years ago
Comment on attachment 615825 [details] [diff] [review]
patch

Sure, looks reasonable.
Attachment #615825 - Flags: review?(jdaggett) → review+
http://hg.mozilla.org/projects/birch/rev/7c9665fc65c8
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/7c9665fc65c8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.