Last Comment Bug 746285 - pack nsXBLBinding more carefully for 64-bit
: pack nsXBLBinding more carefully for 64-bit
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XBL (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Nathan Froyd [:froydnj]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-17 12:39 PDT by Nathan Froyd [:froydnj]
Modified: 2012-04-24 18:05 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.06 KB, patch)
2012-04-17 12:39 PDT, Nathan Froyd [:froydnj]
bzbarsky: review+
Details | Diff | Review

Description Nathan Froyd [:froydnj] 2012-04-17 12:39:48 PDT
Created attachment 615828 [details] [diff] [review]
patch

nsXBLBinding is laid out like so:

  int mRefCnt;
  nsIContent *mBoundElement;
  nsClassHashtable* mInsertionPointTable;
  bool mIsStyleBinding;
  bool mMarkedForDeath;

which introduces padding after mRefCnt and at the end of the structure.  Moving the booleans up into the padding required after mRefCnt saves a word at the end of the structure.
Comment 1 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-04-17 12:43:26 PDT
Comment on attachment 615828 [details] [diff] [review]
patch

r=me
Comment 2 Nathan Froyd [:froydnj] 2012-04-20 13:25:20 PDT
http://hg.mozilla.org/projects/birch/rev/25ed7d0b8433
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2012-04-24 18:05:20 PDT
https://hg.mozilla.org/mozilla-central/rev/25ed7d0b8433

Note You need to log in before you can comment on or make changes to this bug.