Closed Bug 746328 Opened 14 years ago Closed 10 years ago

Disallow 'samples=0' in preference for 'samples=1' meaning single-sampling

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Whiteboard: webgl-internal)

Internally, if we don't want multisampling, we use samples=0. However, samples=1 triggers our multisampling path, but with same results as single-sampling. This is extra unnecessary overhead in cases where cards support multisampling functions but have a GL_MAX_SAMPLES of 1. This would be the case on all GL 4.2+ implementations, iirc, as 4.2 mainlines RenderbufferStorageMultisample, even if cards do not support multisampling. This is also a good change for clarity and predictability's sake.
Whiteboard: webgl-internal
It's most consistent to follow GL's definitions for samples=0 and samples=1.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.