746365 - StrictMode violation in checking Profile Migration status

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Reading the hasMigrationRun preference hits disk on the main thread:

D/StrictMode(15215): StrictMode policy violation; ~duration=207 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=31 violation=2
D/StrictMode(15215): 	at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1067)
D/StrictMode(15215): 	at android.app.SharedPreferencesImpl.awaitLoadedLocked(SharedPreferencesImpl.java:182)
D/StrictMode(15215): 	at android.app.SharedPreferencesImpl.getBoolean(SharedPreferencesImpl.java:239)
D/StrictMode(15215): 	at org.mozilla.gecko.ProfileMigrator.areBookmarksMigrated(ProfileMigrator.java:310)
D/StrictMode(15215): 	at org.mozilla.gecko.ProfileMigrator.hasMigrationRun(ProfileMigrator.java:324)
D/StrictMode(15215): 	at org.mozilla.gecko.GeckoApp.checkMigrateProfile(GeckoApp.java:2296)
D/StrictMode(15215): 	at org.mozilla.gecko.GeckoApp.initialize(GeckoApp.java:1654)
D/StrictMode(15215): 	at org.mozilla.gecko.GeckoApp.onWindowFocusChanged(GeckoApp.java:2025)
D/StrictMode(15215): 	at com.android.internal.policy.impl.PhoneWindow$DecorView.onWindowFocusChanged(PhoneWindow.java:2304)
D/StrictMode(15215): 	at android.view.View.dispatchWindowFocusChanged(View.java:4703)
D/StrictMode(15215): 	at android.view.ViewGroup.dispatchWindowFocusChanged(ViewGroup.java:752)
D/StrictMode(15215): 	at android.view.ViewRoot.handleMessage(ViewRoot.java:2162)
D/StrictMode(15215): 	at android.os.Handler.dispatchMessage(Handler.java:99)
D/StrictMode(15215): 	at android.os.Looper.loop(Looper.java:132)
D/StrictMode(15215): 	at android.app.ActivityThread.main(ActivityThread.java:4126)
D/StrictMode(15215): 	at java.lang.reflect.Method.invokeNative(Native Method)
D/StrictMode(15215): 	at java.lang.reflect.Method.invoke(Method.java:491)
D/StrictMode(15215): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:844)
D/StrictMode(15215): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
D/StrictMode(15215): 	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Gian-Carlo Pascutto [:gcp]]

We can hit this on every startup and there's a potential startup time regression.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Run everything on the background thread

Comment 3

[Gian-Carlo Pascutto [:gcp]]

FWIW, this was caused by Bug 715550 splitting Sync Migration and Profile Migration and moving the latter earlier in the startup. The SharedPreference check is really the only thing outside the handler, but indeed that does mean a read from disk.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1008d8219540

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1008d8219540