keywords set by pop3 incoming filters aren't written into the berkeley mailbox

VERIFIED FIXED in Thunderbird 14.0

Status

MailNews Core
Backend
P1
major
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Trunk
Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird12+ fixed, thunderbird13+ fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 615911 [details] [diff] [review]
this uses an output stream for new messages that is also an input stream.

pop3 filters on new incoming messages don't write the keywords into the mailbox, which means if the folder is reparsed, we'll lose the keywords. The issue is that the output stream that berkeley mailboxes use for new messages isn't also an input stream, which means that the change keywords code can't get an input stream to figure out where to write the keyword change.

I believe flag changes would also have this issue.

I have a relatively simple fix for this. I'll try to write a test for it as well. The fix will mean that you can change flags while download is going on, which didn't used to be the case. The pop3 download code always seeks to the end of the stream before writing data, so we shouldn't get issues of messages getting written into the middle of the folder, but I'd want to bang on it for a bit to make sure.
(Assignee)

Comment 1

5 years ago
Created attachment 615944 [details] [diff] [review]
adds unit test, fixes mark read and flagged actions

I discovered mark read/unread and mark flagged pop3 filter actions weren't going through the folder.
Attachment #615911 - Attachment is obsolete: true
Attachment #615944 - Flags: review?(mbanner)
(Assignee)

Updated

5 years ago
Severity: normal → major
Status: NEW → ASSIGNED
status-thunderbird12: --- → affected
status-thunderbird13: --- → affected
status-thunderbird14: --- → affected
tracking-thunderbird12: --- → +
tracking-thunderbird13: --- → +
tracking-thunderbird14: --- → +
Priority: -- → P1
(Assignee)

Comment 2

5 years ago
Created attachment 615948 [details] [diff] [review]
remove commented out code
Attachment #615944 - Attachment is obsolete: true
Attachment #615944 - Flags: review?(mbanner)
Attachment #615948 - Flags: review?(mbanner)
(Assignee)

Comment 3

5 years ago
I've requested a try server build w/ this patch - http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/bienvenu@nventure.com-82cc58b3f954

Updated

5 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Comment on attachment 615948 [details] [diff] [review]
remove commented out code

Review of attachment 615948 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r+a=me.
Attachment #615948 - Flags: review?(mbanner)
Attachment #615948 - Flags: review+
Attachment #615948 - Flags: approval-comm-beta+
Attachment #615948 - Flags: approval-comm-aurora+
Checked in:

http://hg.mozilla.org/comm-central/rev/f7856c1e7a5e
http://hg.mozilla.org/releases/comm-aurora/rev/3d4ba86a976d
http://hg.mozilla.org/releases/comm-beta/rev/33ee8cf6630f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-thunderbird12: affected → fixed
status-thunderbird13: affected → fixed
status-thunderbird14: affected → ---
tracking-thunderbird14: + → ---
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Checked Tb truk 4/19 build on Win-XP.
> Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20120419 Thunderbird/14.0a1

Filter rule actions.
> type="1"
> action="AddTag"
> actionValue="zz"
> action="Mark read"
> action="Mark flagged"
> action="Move to folder"
> actionValue="mailbox:// ... "

After filter application upon download, following header was written in move target folder.
> X-Mozilla-Status: 0005
> X-Mozilla-Status2: 00000000
> X-Mozilla-Keys: xx

VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.