746394 - No label for home screen icons when adding page without title

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

If a page without a title is added to the home screen, the label below the icon is empty. We should use something, such as the page URL, when the title is empty.

Comment 1

[:Margaret Leibovic]

Attachment: patch

This totally bothered me the other day - I should have filed a bug.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I hope the OS crops the URL when shown on the homescreen. I think it does.

Comment 3

[Wesley Johnston (:wesj)]

Maybe we should strip the http (and www if its there)?

Comment 4

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> I hope the OS crops the URL when shown on the homescreen. I think it does.

It does.

(In reply to Wesley Johnston (:wesj) from comment #3)
> Maybe we should strip the http (and www if its there)?

Yeah, that seems like a good idea, since we don't have much space to work with. I was also thinking about just using the name of the file at the end of the path, since we do something like that for downloads, but that seems less informative than the domain.

Comment 5

[:Margaret Leibovic]

Attachment: alternate patch

This patch also strips the protocol from the url. This is more complicated, and I'm not sure if it's worth the extra effort.

Comment 6

[:Margaret Leibovic]

Attachment: patch using regex

This gets rid of the protocol and the "www." if it exists.

I'm trying to think of ways this regex can break, but it seems okay to me. I tested this with:
"http://www.foo.com"
"foo://foo.com"
"http://wwww.foo.com"
"http://ww.foo.com"

Comment 7

[:Margaret Leibovic]

Comment on attachment 616215 [details] [diff] [review]
patch using regex

Self-contained change that will only affect adding a title-less page to your home screen. And it's a nice small win to avoid title-less icons on your home screen.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 616215 [details] [diff] [review]
patch using regex

low risk and we hope people start using home screen shortcuts to launch the browser

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/566721f5c440

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/566721f5c440

Comment 11

[Peter Retzer (:pretzer)]

Can the protocol stripping part of this bug be used in any way for bug 729495 ? If yes, maybe it would be nice to add a comment there about this implementation for future reference. Can you do that Margaret?