746422 - nsTextBoxFrame doesn't include glpyh overflow in its overflow rects

Status: RESOLVED DUPLICATE of bug 746421

(Core :: Layout: Text and Fonts, defect)

Description

[Matt Woodrow (:mattwoodrow)]

XUL text frames only use the tight extents of the text for their size, they never include the loose extents in the overflow area.

This causes incorrect invalidation, and with DLBI patches, test failures.

Somewhat guessing with the attached patch, running it on tryserver now to see if it fixes the test failures.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Include the LOOSE_INK_EXTENTS

Comment 2

[Takanori MATSUURA]

Dup. of bug 746421?

Comment 4

[Matt Woodrow (:mattwoodrow)]

In addition to this, it appears that we are only using the LOOSE_INK_EXTENTS with normal html text frames when we recompute the overflow area. The initial reflow uses TIGHT_HINTED_OUTLINE_EXTENTS (except when IsFloatingFirstLetterChild() - not sure what that means).

See:
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsTextFrameThebes.cpp#7451

http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsTextFrameThebes.cpp#7916

I believe a similar bug also exists for nsMathMLChar, harder to figure out the measurement code there though.

Does anyone have time to help with this? It's blocking DLBI patches from landing.

Alternatively I can just extend the invalidation areas of text temporarily until we can fix this properly.