746526 - Missing unistd.h include in IPC files

Status: RESOLVED DUPLICATE of bug 736765

(Core :: IPC, defect)

Description

[Pierre Réveillon]

Attachment: Build error full log

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120401163544

Steps to reproduce:

Compiling Firefox (mozilla-release or mozilla-beta), simply with "make -f client.mk", without specific mozconfig.


Actual results:

A compilation error occured: (Full log attached)

message_pump_libevent.cc
c++ -o message_pump_libevent.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /home/grubshka/devel/mozilla/mozilla-beta/config/gcc_hidden.h -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DOSTYPE=\"Linux3.3\" -DOSARCH=Linux -DEXCLUDE_SKIA_DEPENDENCIES  -DOS_LINUX=1 -DOS_POSIX=1  -DHAVE_CONFIG_H -I/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src -I/home/grubshka/devel/mozilla/mozilla-beta/ipc/glue -I../../ipc/ipdl/_ipdlheaders  -I/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/third_party/libevent -I/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/third_party/libevent/linux -I/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium -I. -I../../dist/include -I../../dist/include/nsprpub  -I/home/grubshka/devel/mozilla/mozilla-beta/obj-x86_64-unknown-linux-gnu/dist/include/nspr -I/home/grubshka/devel/mozilla/mozilla-beta/obj-x86_64-unknown-linux-gnu/dist/include/nss      -fPIC -fno-rtti -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -Wno-long-long -fno-exceptions -fno-strict-aliasing -std=gnu++0x -pthread -ffunction-sections -fdata-sections -pipe -DNDEBUG -DTRIMMED -g -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/gtk-unix-print-2.0   -Os -freorder-blocks  -fomit-frame-pointer   -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MF .deps/message_pump_libevent.pp /home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc: In static member function ‘static void base::MessagePumpLibevent::OnWakeup(int, short int, void*)’:
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc:91:15: erreur: ‘read’ was not declared in this scope
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc:91:15: erreur: invalid type in declaration before ‘;’ token
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc: In member function ‘bool base::MessagePumpLibevent::Init()’:
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc:109:15: erreur: ‘pipe’ was not declared in this scope
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc: In destructor ‘virtual base::MessagePumpLibevent::~MessagePumpLibevent()’:
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc:140:26: erreur: ‘close’ was not declared in this scope
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc:142:27: erreur: ‘close’ was not declared in this scope
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc: In member function ‘virtual void base::MessagePumpLibevent::ScheduleWork()’:
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc:359:16: erreur: ‘write’ was not declared in this scope
/home/grubshka/devel/mozilla/mozilla-beta/ipc/chromium/src/base/message_pump_libevent.cc:359:16: erreur: invalid type in declaration before ‘;’ token
make[6]: *** [message_pump_libevent.o] Erreur 1
make[6] : on quitte le répertoire « /home/grubshka/devel/mozilla/mozilla-beta/obj-x86_64-unknown-linux-gnu/ipc/chromium »



Expected results:

Compilation should work.

Comment 1

[Pierre Réveillon]

I added unistd.h include to message_pump_libevent.cc, it build but gave the same error on another file.
Finally, adding unistd.h to file_util_linux.cc, message_pump_libevent.cc, and time_posix.cc fixed all problems.

See patch in attachment.

Comment 2

[Pierre Réveillon]

Attachment: Patch to add #include <unistd.h>

Seems to be the same a

Comment 3

[Pierre Réveillon]

Seems to be the same as bug 736765.

Comment 4

[Pierre Réveillon]

OK, sorry, this is a duplicate of bug 736765, since the patch fix all missing includes.