746541 - Assert that nsXPConnect::ReleaseXPConnectSingleton removes last reference to nsXPConnect

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: fix it and add assert

The debug code in nsXPConnect::ReleaseXPConnectSingleton expects it is the one to remove the last reference to nsXPConnect. Unfortunately, this is not the case right now, but it is easy to fix.

This patch fixes it and adds an assert to make the assumption explicit.
https://tbpl.mozilla.org/?tree=Try&rev=e4087eb0fe8d

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

The assert found an existing leak in xpcshell-tests. I pushed with out the assert to

https://tbpl.mozilla.org/?tree=Birch&rev=0808c7e0388e

We can enable the assert once billm fixes the leak

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/0808c7e0388e