Closed
Bug 746545
Opened 13 years ago
Closed 13 years ago
remove duplicate mozinfo.py files
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Whiteboard: [mozbase])
Attachments
(1 file)
8.57 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
we have two instances of mozinfo:
m-c/build/mozinfo.py
m-c/testing/mozbase/mozinfo/mozinfo/mozinfo.py
Currently the build/mozinfo.py script is used in xpcshell automation. We need to fix the makefiles that reference mozinfo.py to use the location in mozbase. In a perfect world, we would convert xpcshell to run in a virtualenv as we do for other tests.
Comment 1•13 years ago
|
||
Let's remove the one in build/. Running xpcshell-tests from the objdir should use the virtualenv one just fine. We'll have to fix the xpcshell test packaging to package the copy from testing/mozbase (until we figure out a better solution for the virtualenv in the test package).
Assignee | ||
Comment 2•13 years ago
|
||
simple patch to just do the file copying. In the near future we will want to use the virtualenv for running the tests and then we won't need all the file copying.
Updated•13 years ago
|
Attachment #617869 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Assignee | ||
Comment 5•13 years ago
|
||
we need to add -I in these two spots:
* http://mxr.mozilla.org/mozilla-central/source/testing/testsuite-targets.mk#241
* http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#114
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•13 years ago
|
||
There's already a bug filed on the bustage, just patch it there.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•