746570 - Codegen.py has lots of cases of using rstrip() where it means stripTrailingWhitespace()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Because otherwise blank lines in the middle of the text getting processed will get whitespace on them.

Alternately, more use of CGIndenter?  ;)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Get rid of bogus uses of rstrip() that are leaving random trailing spaces in the middle of our string.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 632908 [details] [diff] [review]
Get rid of bogus uses of rstrip() that are leaving random trailing spaces in the middle of our string.

Review of attachment 632908 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +3212,5 @@
>              (memberString, lastVisibility, itemCount) = \
>                  declareMembers(self, memberList, lastVisibility, itemCount,
>                                 separator)
>              if self.indent:
> +                memberString = CGIndenter(CGGeneric(memberString)).define()

Shouldn't this use len(self.indent)?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Shouldn't this use len(self.indent)?

Yes, indeed.  Will fix.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f7ab21fde07

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3f7ab21fde07