746588 - [Azure] Cairo-pattern matrices specify the conversion from DrawTarget to pattern but Azure is inverted

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[George Wright (:gw280) (needinfo me!)]

Matrices in Azure specify the conversion from pattern to DT space; we do not handle this in gfxPattern.cpp in SetMatrix()

Comment 1

[George Wright (:gw280) (needinfo me!)]

Attachment: invert the matrix in SetMatrix

Patch from Bas

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 616152 [details] [diff] [review]
invert the matrix in SetMatrix

Review of attachment 616152 [details] [diff] [review]:
-----------------------------------------------------------------

Does this affect D2D?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 616152 [details] [diff] [review]
invert the matrix in SetMatrix

Review of attachment 616152 [details] [diff] [review]:
-----------------------------------------------------------------

Does this affect D2D?

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 616152 [details] [diff] [review]
invert the matrix in SetMatrix

Review of attachment 616152 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPattern.cpp
@@ +134,5 @@
>      mTransform = ToMatrix(matrix);
> +    // Cairo-pattern matrices specify the conversion from DrawTarget to pattern
> +    // space. Azure pattern matrices specify the conversion from pattern to
> +    // DrawTarget space.
> +    mTransform.Invert();

should this be azure only then?

Comment 5

[George Wright (:gw280) (needinfo me!)]

Yes, this only affects azure for content drawing with basic layers.

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 616152 [details] [diff] [review]
invert the matrix in SetMatrix

[Triage Comment]
Desktop only, approved for central.

Comment 7

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d400d7f9eadd

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/d400d7f9eadd